Skip to content

Add default notebook feature and delete action for Zed editor - #62648

Open
Pujan-Dev wants to merge 3 commits into
zed-industries:mainfrom
Pujan-Dev:fix/notebooks
Open

Add default notebook feature and delete action for Zed editor#62648
Pujan-Dev wants to merge 3 commits into
zed-industries:mainfrom
Pujan-Dev:fix/notebooks

Conversation

@Pujan-Dev

Copy link
Copy Markdown

Objective

Improve notebook cell deletion to prevent accidental data loss by requiring confirmation before a cell is deleted. This PR also enables the notebooks feature flag for all users by default.

Solution

  • Added a new DeleteCurrentCell action that prompts the user for confirmation before deleting the currently selected notebook cell.
  • Updated the notebook UI delete button and tooltip to use DeleteCurrentCell instead of directly deleting the cell.
  • Added the required prompt and error-handling support for the confirmation flow.
  • Enabled the notebooks feature flag for all users by having NotebookFeatureFlag::enabled_for_all() return true.
  • Made minor code organization and action-handling improvements related to notebook cell deletion.

Testing

  • Tested the notebook cell deletion flow and verified that selecting delete displays a confirmation prompt.
  • Verified that the cell is deleted only after the user confirms.
  • Verified that cancelling the prompt leaves the notebook cell unchanged.
  • Verified that the notebook feature is available without user-specific feature flag configuration.
  • Additional testing of notebook cell deletion across supported platforms would be useful.

Self-Review Checklist:

Showcase

Click to view showcase

When deleting a notebook cell, Zed now displays a confirmation prompt before performing the deletion. Confirming removes the selected cell, while cancelling preserves it.

this image have the delete button logo on the side as per the zed's ui. image

this issue was raised on the
Release Notes:

  • Improved: Added a confirmation prompt when deleting notebook cells to help prevent accidental data loss.
  • Improved: Enabled the notebooks feature for all users by default.

@cla-bot cla-bot Bot added the cla-signed The user has signed the Contributor License Agreement label Aug 14, 2026
@zed-community-bot zed-community-bot Bot added the first contribution the author's first pull request to Zed. NOTE: the label application is automated via github actions label Aug 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement first contribution the author's first pull request to Zed. NOTE: the label application is automated via github actions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant