Remove explicit installation of tree-sitter CLI in CI check job #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbannier
force-pushed
the
topic/bbannier/ci-consistent-tree-sitter-version
branch
3 times, most recently
from
28724ac to
a95b225
Compare
The GH action `tree-sitter/setup-action/cli` defaults to using the latest version of tree-sitter while we already already capture the tree-sitter version we build against in `package.json`. This duplication was not only unnecessary, but it also lead to version conflicts when checking whether generated files were up-to-date. This instead uses the tree-sitter CLI version as encoded for npm.
bbannier
force-pushed
the
topic/bbannier/ci-consistent-tree-sitter-version
branch
from
a95b225 to
5f91be1
Compare
bbannier
deleted the
topic/bbannier/ci-consistent-tree-sitter-version
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GH action
tree-sitter/setup-action/clidefaults to using the latest version of tree-sitter while we already already capture the tree-sitter version we build against inpackage.json. This duplication was not only unnecessary, but it also lead to version conflicts when checking whether generated files were up-to-date. This instead uses the tree-sitter CLI version as encoded for npm.