Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Ensure Cmd + Enter in URL bar always opens in a new tab #5449

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

KailashGanesh
Copy link

Fix for Issue #5200

Problem

Pressing Cmd + Enter in the URL bar behaved inconsistently depending on how the URL bar was selected:

  • Cmd + L → Opened in a new tab
  • Cmd + T → Opened in the same tab

Bug demonstration:
gif of issue

Fix

Now, Cmd + Enter will consistently open the URL in a new tab, regardless of whether the URL bar was selected using Cmd + L or Cmd + T.

Fix demonstration:
gif of fix

Let me know if any improvements are needed

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. Bug labels Feb 16, 2025
@KailashGanesh KailashGanesh changed the title Fix/meta enter url bar Fix: Ensure Cmd + Enter in URL bar always opens in a new tab Feb 16, 2025
@huseyingulec
Copy link

I think your bug is already fixed on twilight but not in zen browser 1.7.6b beta.

cmd + L => opens in the same tab
cmd + T => opens a new tab

this is expected behaviour and currently works as it is in twilight.

why do you need an extra step to open a new tap by adding cmd + enter?

@KailashGanesh
Copy link
Author

KailashGanesh commented Feb 16, 2025

cmd + L => opens in the same tab
cmd + T => opens a new tab

this is expected behaviour and currently works as it is in twilight.

You are right about cmd + L and cmd + T being for URL bar selection and new tabs.

why do you need an extra step to open a new tap by adding cmd + enter?

The cmd + enter bug fix is about consistent behavior with browsers like Chrome / Arc. pressing cmd + enter after typing a URL in the address bar will always open it in a new tab in those browsers.

In Zen, if you use cmd + L, type url and then press cmd + enter it would open URL in new tab
but if you use cmd + T, type url and then press cmd + enter it would open URL in the same (already occupied) tab

@KailashGanesh
Copy link
Author

Hi @mauro-balades Gentle reminder to check this PR, Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants