Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve HTML semantics and buttons animation #428

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

SebastianL-dev
Copy link

  • Improved HTML semantics and fix buttons hover transition.

@mauro-balades
Copy link
Member

Hi! Could we see how it look now?

@SebastianL-dev
Copy link
Author

Hey, the design its the same, i just fixed some HTML semantics, and the buttons transitions its better, before all buttons have no transitions, now have fade transition on hover.

Screen.Recording.2025-01-24.213418.mp4

It's a little change but i think that look much better.

@mauro-balades
Copy link
Member

Doesn't it break the initial animations though?

@SebastianL-dev
Copy link
Author

Nope, it doesn't, you can see it in the video 😊

@ConwayTech-Dev
Copy link
Contributor

Hey, nice work! This change seems fine for the most part, but it does break the color of the "Start Exploring" button. On the main version, it's dark (to contrast it from the "Download" button), but on your version, it's light. Shouldn't be too hard to fix.

There might be some other color issues too, but that's the main one that I noticed.

@SebastianL-dev
Copy link
Author

SebastianL-dev commented Jan 27, 2025

Hey, sorry for that, i didn't realize about that, i will fix it and update this pull request, thank you. 😊

@SebastianL-dev
Copy link
Author

  • Fixed buttons transitions, now looks better and don't break the contrast in buttons.
Screen.Recording.2025-01-27.135619.mp4

Hey, i fixed the transitions, now the transitions looks better and it doesn't break the contrast.

@NOCanoa NOCanoa requested a review from mauro-balades January 31, 2025 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants