Skip to content
This repository has been archived by the owner on Jan 30, 2020. It is now read-only.

Fix: Allow to install phpunit/phpunit:^5.2 #54

Merged
merged 1 commit into from
May 17, 2017

Conversation

localheinz
Copy link
Member

❗️ Blocks #53.

This PR

  • allows to install phpunit/phpunit:^5.2 to fix failing tests

💁‍♂️ This fixes an issue where tests are failing with

PHP Fatal error:  Call to undefined method ZendTest\Hydrator\HydratorPluginManagerCompatibilityTest::expectException() in /Users/am/Sites/zendframework/zend-hydrator/vendor/zendframework/zend-servicemanager/src/Test/CommonPluginManagerTrait.php on line 56
PHP Stack trace:
PHP   1. {main}() /Users/am/Sites/zendframework/zend-hydrator/vendor/phpunit/phpunit/phpunit:0
PHP   2. PHPUnit_TextUI_Command::main() /Users/am/Sites/zendframework/zend-hydrator/vendor/phpunit/phpunit/phpunit:52
PHP   3. PHPUnit_TextUI_Command->run() /Users/am/Sites/zendframework/zend-hydrator/vendor/phpunit/phpunit/src/TextUI/Command.php:100
PHP   4. PHPUnit_TextUI_TestRunner->doRun() /Users/am/Sites/zendframework/zend-hydrator/vendor/phpunit/phpunit/src/TextUI/Command.php:149
PHP   5. PHPUnit_Framework_TestSuite->run() /Users/am/Sites/zendframework/zend-hydrator/vendor/phpunit/phpunit/src/TextUI/TestRunner.php:440
PHP   6. PHPUnit_Framework_TestSuite->run() /Users/am/Sites/zendframework/zend-hydrator/vendor/phpunit/phpunit/src/Framework/TestSuite.php:722
PHP   7. PHPUnit_Framework_TestCase->run() /Users/am/Sites/zendframework/zend-hydrator/vendor/phpunit/phpunit/src/Framework/TestSuite.php:722
PHP   8. PHPUnit_Framework_TestResult->run() /Users/am/Sites/zendframework/zend-hydrator/vendor/phpunit/phpunit/src/Framework/TestCase.php:724
PHP   9. PHPUnit_Framework_TestCase->runBare() /Users/am/Sites/zendframework/zend-hydrator/vendor/phpunit/phpunit/src/Framework/TestResult.php:612
PHP  10. PHPUnit_Framework_TestCase->runTest() /Users/am/Sites/zendframework/zend-hydrator/vendor/phpunit/phpunit/src/Framework/TestCase.php:768
PHP  11. ReflectionMethod->invokeArgs() /Users/am/Sites/zendframework/zend-hydrator/vendor/phpunit/phpunit/src/Framework/TestCase.php:909
PHP  12. ZendTest\Hydrator\HydratorPluginManagerCompatibilityTest->testRegisteringInvalidElementRaisesException() /Users/am/Sites/zendframework/zend-hydrator/vendor/phpunit/phpunit/src/Framework/TestCase.php:909

For reference, also see the corresponding changelog.

@localheinz
Copy link
Member Author

Not sure if this is the right approach, but it seems that the build failure in current master is related to zendframework/zend-servicemanager@07d53d3#diff-5c31378e6c0ded5e0a98924896877727.

/cc @kokspflanze

@kokspflanze
Copy link
Contributor

@localheinz fyi zendframework/zend-servicemanager#182

i have today a bit space, so i can update today this module to phpunit5/6 to solve this problem here.

@localheinz
Copy link
Member Author

@kokspflanze

Ha, thanks a ton! 👍

@localheinz
Copy link
Member Author

@kokspflanze

If you like, I can also take stab at this one, no problem!

@kokspflanze
Copy link
Contributor

@localheinz i start with that shit, so i have to life with it=)

@localheinz
Copy link
Member Author

@kokspflanze

Ha, no problem, but there's quite a bunch of repositories, hehe!

@kokspflanze
Copy link
Contributor

@localheinz
check #55 =)

some modules done, and im happy about help.

weierophinney added a commit that referenced this pull request May 17, 2017
Fix: Allow to install phpunit/phpunit:^5.2

Conflicts:
	composer.json
	composer.lock
weierophinney added a commit that referenced this pull request May 17, 2017
Forward port #25
Forward port #30
Forward port #31
Forward port #32
Forward port #33
Forward port #34
Forward port #35
Forward port #36
Forward port #37
Forward port #41
Forward port #43
Forward port #54
Forward port #55
Forward port #56
Forward port #57
Forward port #58
@weierophinney weierophinney merged commit 54b1dec into zendframework:master May 17, 2017
weierophinney added a commit that referenced this pull request May 17, 2017
Close #25
Close #30
Close #31
Close #32
Close #33
Close #34
Close #35
Close #36
Close #37
Close #41
Close #43
Close #54
Close #55
Close #56
Close #57
Close #58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants