Skip to content

Commit

Permalink
Planning
Browse files Browse the repository at this point in the history
  • Loading branch information
dumbmatter committed Nov 29, 2023
1 parent e6d2dff commit 1b6df86
Show file tree
Hide file tree
Showing 3 changed files with 16 additions and 31 deletions.
30 changes: 14 additions & 16 deletions TODO
Original file line number Diff line number Diff line change
Expand Up @@ -2,22 +2,20 @@ better play by play log
- test other sports
- baseball
- pitch events logo
- showScore in LiveGame
- does this UI make sense?
- benchmark
- make text JSX, get rid of any processing in LiveGame
- test performance
- see commented out stuff in LiveGame
- slow! should take about 10 seconds at fastest speed to sim game, instead takes 32
- virtualize?
- might be tricky
- breaks ctrl+f
- go back to editing DOM?
- then i still can't use jsx in processLiveGameEvents text output
- maybe not that slow in prod mode, benchmark
- colored text for football interceptions/fumble/downs turnovers, hockey penalty, maybe baseball outs, maybe baseball/hockey/football scores

no need to track scoringSummary at all for basketball
- showOuts stuff - where to display?
- benchmark - no low hanging find fruit!
- commented out stuff in LiveGame
- colored text
- red: football interceptions/fumble/downs turnovers, hockey penalty, maybe baseball outs
- green: baseball/hockey/football scores
- should score be shown more prominently, somehow?
- blog
- UI differences across sports
- performance
- old way
- new way - has some advantages
- virtualize? breaks ctrl+f
- in hockey/football, found some ways to optimize performance to offset the change

some sportState live sim for basketball/hockey
- chart showing margin vs time or win probability vs time (toggle button to switch)
Expand Down
13 changes: 0 additions & 13 deletions src/ui/views/LiveGame.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -286,19 +286,6 @@ export const LiveGame = (props: View<"liveGame">) => {
endWithPeriod ? "." : ""
}`;
}
}
const p = document.createElement("p");
const node = document.createTextNode(text);
if (
(isSport("hockey") &&
(text.includes("Goal!") || text.includes("penalty"))) ||
) {
const b = document.createElement("b");
b.appendChild(node);
p.appendChild(b);
} else {
p.appendChild(node);
}*/

const score =
Expand Down
4 changes: 2 additions & 2 deletions src/worker/core/GameSim.basketball/PlayByPlayLogger.ts
Original file line number Diff line number Diff line change
Expand Up @@ -297,7 +297,7 @@ class PlayByPlayLogger {

playByPlay: PlayByPlayEvent[] = [];

scoringSummary: PlayByPlayEventScore[] = [];
// scoringSummary: PlayByPlayEventScore[] = [];

period = 1;

Expand All @@ -315,7 +315,7 @@ class PlayByPlayLogger {
...event,
period: this.period,
};
this.scoringSummary.push(event2);
// this.scoringSummary.push(event2);
if (this.active) {
this.playByPlay.push(event2);
}
Expand Down

0 comments on commit 1b6df86

Please sign in to comment.