Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update copier command in test-migrations.sh #2169

Merged
merged 3 commits into from
Dec 20, 2023

Conversation

strickvl
Copy link
Contributor

This pull request updates the copier command in the test-migrations.sh file to use the latest release tag of the template-starter repository. This ensures that the correct version of the template-starter is used when running the tests.

@strickvl strickvl added bug Something isn't working internal To filter out internal PRs and issues labels Dec 20, 2023
@strickvl strickvl requested a review from avishniakov December 20, 2023 15:46
Copy link
Contributor

coderabbitai bot commented Dec 20, 2023

Important

Auto Review Skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on X ?


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • You can reply to a review comment made by CodeRabbit.
  • You can tag CodeRabbit on specific lines of code or files in the PR by tagging @coderabbitai in a comment.
  • You can tag @coderabbitai in a PR comment and ask one-off questions about the PR and the codebase. Use quoted replies to pass the context for follow-up questions.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

strickvl and others added 2 commits December 20, 2023 16:47
Co-authored-by: Andrei Vishniakov <[email protected]>
Co-authored-by: Andrei Vishniakov <[email protected]>
@strickvl strickvl requested a review from avishniakov December 20, 2023 15:47
@strickvl strickvl merged commit b506d4a into develop Dec 20, 2023
4 of 10 checks passed
@strickvl strickvl deleted the bugfix/copier-version-failure branch December 20, 2023 15:48
@@ -15,8 +15,7 @@ function run_tests_for_version() {
# Initialize zenml with the appropriate template
# hardcoded to 0.43.0 since this is the latest template-starter repo
# release tag
git clone -b "release/0.43.0" https://github.com/zenml-io/template-starter
copier copy template-starter/ test_starter --trust --defaults
copier copy --trust -l --trust -r release/0.43.0 https://github.com/zenml-io/template-starter.git test_starter
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
copier copy --trust -l --trust -r release/0.43.0 https://github.com/zenml-io/template-starter.git test_starter
copier copy -l --trust -r release/0.43.0 https://github.com/zenml-io/template-starter.git test_starter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working internal To filter out internal PRs and issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants