Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Importlib import fix for DB migration testing #2171

Merged
merged 3 commits into from
Dec 20, 2023

Conversation

strickvl
Copy link
Contributor

@strickvl strickvl commented Dec 20, 2023

DB migration testing bug fix (relating to importlib_metadata package import error.
Also added some more recent versions to the tests.

WARNING: make sure to delete the test workflow from this PR BEFORE MERGING!

Pre-requisites

Please ensure you have done the following:

  • I have read the CONTRIBUTING.md document.
  • If my change requires a change to docs, I have updated the documentation accordingly.
  • If I have added an integration, I have updated the integrations table and the corresponding website section.
  • I have added tests to cover my changes.
  • I have based my new branch on develop and the open PR is targeting develop. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Other (add details above)

Summary by CodeRabbit

  • New Features

    • Introduced a new workflow for testing MySQL database migrations, enhancing the robustness of database changes.
  • Enhancements

    • Updated the migration testing script to include more versions, ensuring broader compatibility checks.
  • Documentation

    • No public entity declarations added in this release.

@strickvl strickvl added bug Something isn't working internal To filter out internal PRs and issues labels Dec 20, 2023
@strickvl strickvl requested a review from avishniakov December 20, 2023 16:36
Copy link
Contributor

coderabbitai bot commented Dec 20, 2023

Important

Auto Review Skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Walkthrough

The project has updated its CI testing workflow to include new MySQL database migration tests. This update adds support for testing additional versions of the software, specifically versions "0.51.0" and "0.52.0". The testing script has also been improved to handle dependencies differently for versions newer than "0.47.0".

Changes

File Path Change Summary
.github/workflows/.../ci_test.yml Introduced a workflow for testing MySQL database migrations, specifying trigger events and environment setup.
scripts/test-migrations.sh Updated to test new versions "0.51.0" and "0.52.0"; modified conditional logic for importlib_metadata installation for versions > "0.47.0".

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on X ?


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • You can reply to a review comment made by CodeRabbit.
  • You can tag CodeRabbit on specific lines of code or files in the PR by tagging @coderabbitai in a comment.
  • You can tag @coderabbitai in a PR comment and ask one-off questions about the PR and the codebase. Use quoted replies to pass the context for follow-up questions.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

@strickvl
Copy link
Contributor Author

@coderabbitai review

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: .coderabbit.yaml

Commits Files that changed from the base of the PR and between fad464d and ebd449b.
Files selected for processing (2)
  • .github/workflows/ci_test.yml (1 hunks)
  • scripts/test-migrations.sh (2 hunks)
Additional comments: 3
.github/workflows/ci_test.yml (1)
  • 1-18: The workflow is well-defined and triggers on the correct events. However, ensure that the warning in the PR about deleting the test workflow before merging is adhered to, to prevent unintended consequences.
scripts/test-migrations.sh (2)
  • 50-50: Adding versions "0.51.0" and "0.52.0" to the VERSIONS array is correct. Ensure that these versions are indeed intended to be included in the migration tests and that they are compatible with the rest of the testing environment.

  • 71-77: The conditional logic for installing importlib_metadata for Python 3.9 and versions above "0.47.0" is correct. However, ensure that this package is indeed not required for other Python versions or that it doesn't lead to inconsistencies in the testing environment across different Python versions.

@strickvl strickvl merged commit 640a7bb into develop Dec 20, 2023
3 of 19 checks passed
@strickvl strickvl deleted the bugfix/importlib-import-fix branch December 20, 2023 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working internal To filter out internal PRs and issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants