-
Notifications
You must be signed in to change notification settings - Fork 476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Importlib import fix for DB migration testing #2171
Conversation
Important Auto Review SkippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the To trigger a single review, invoke the WalkthroughThe project has updated its CI testing workflow to include new MySQL database migration tests. This update adds support for testing additional versions of the software, specifically versions "0.51.0" and "0.52.0". The testing script has also been improved to handle dependencies differently for versions newer than "0.47.0". Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on X ? TipsChat with CodeRabbit Bot (
|
@coderabbitai review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: .coderabbit.yaml
Files selected for processing (2)
- .github/workflows/ci_test.yml (1 hunks)
- scripts/test-migrations.sh (2 hunks)
Additional comments: 3
.github/workflows/ci_test.yml (1)
- 1-18: The workflow is well-defined and triggers on the correct events. However, ensure that the warning in the PR about deleting the test workflow before merging is adhered to, to prevent unintended consequences.
scripts/test-migrations.sh (2)
50-50: Adding versions "0.51.0" and "0.52.0" to the
VERSIONS
array is correct. Ensure that these versions are indeed intended to be included in the migration tests and that they are compatible with the rest of the testing environment.71-77: The conditional logic for installing
importlib_metadata
for Python 3.9 and versions above "0.47.0" is correct. However, ensure that this package is indeed not required for other Python versions or that it doesn't lead to inconsistencies in the testing environment across different Python versions.
DB migration testing bug fix (relating to importlib_metadata package import error.
Also added some more recent versions to the tests.
WARNING: make sure to delete the test workflow from this PR BEFORE MERGING!
Pre-requisites
Please ensure you have done the following:
develop
and the open PR is targetingdevelop
. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.Types of changes
Summary by CodeRabbit
New Features
Enhancements
Documentation