Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove space saver action + upgrade other actions #2174

Merged
merged 3 commits into from
Dec 22, 2023
Merged

Remove space saver action + upgrade other actions #2174

merged 3 commits into from
Dec 22, 2023

Conversation

strickvl
Copy link
Contributor

@strickvl strickvl commented Dec 20, 2023 •
edited by coderabbitai bot
Loading

Overdue to upgrade / update some of our really ancient or deprecated actions.

Also since we're on custom runners for ubuntu I removed the special action that was clearing space on the runner. (Should save a bit of time).

Summary by CodeRabbit

  • Chores
    • Updated GitHub Actions to newer versions across various workflow files for improved performance and security.

@strickvl strickvl added enhancement New feature or request internal To filter out internal PRs and issues dependencies Pull requests that update a dependency file labels Dec 20, 2023
@strickvl strickvl requested a review from avishniakov December 20, 2023 18:43
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 20, 2023 •
edited
Loading

Walkthrough

Walkthrough

The changes across various GitHub action workflow files reflect a series of updates to the versions of actions used, including actions/checkout, actions/setup-python, and other specific actions like calibreapp/image-actions, team-labeler-action, pr-labeler-action, and aquasecurity/trivy-action. These updates suggest an effort to leverage new features, improvements, or security patches that come with the newer versions of these actions.

Changes

File Path Change Summary
.github/actions/setup_environment/action.yml Updated actions/setup-python from v4 to v5.0.0
.github/workflows/.../ci.yml Updated actions/checkout from v2 to v4.1.1, actions/setup-python from v2 to v5.0.0
.github/workflows/.../codeql.yml Updated actions/checkout from v3 to v4.1.1
.github/workflows/.../image-optimiser.yml Updated actions/checkout from v3 to v4.1.1, calibreapp/image-actions from main to 1.1.0
.github/workflows/.../integration-test.yml, .github/workflows/.../mixpanel-test-data.yml, .github/workflows/.../pr_labeler.yml, .github/workflows/.../publish_api_docs.yml, .github/workflows/.../publish_docker_image.yml, .github/workflows/.../publish_helm_chart.yml, .github/workflows/.../publish_to_pypi.yml, .github/workflows/.../publish_to_pypi_nightly.yml, .github/workflows/.../release.yml, .github/workflows/.../setup-python-environment.yml Updated versions of various actions used within the workflow steps
.github/workflows/.../trivy-zenml-core.yml, .github/workflows/.../trivy-zenserver.yml Updated actions/checkout and aquasecurity/trivy-action versions
.github/workflows/.../update-templates-to-examples.yml Updated actions/checkout and actions/github-script versions
.github/workflows/.../replace_api_docs_version Updated actions/checkout version and API documentation links

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on X ?

Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • You can reply to a review comment made by CodeRabbit.
  • You can tag CodeRabbit on specific lines of code or files in the PR by tagging @coderabbitai in a comment.
  • You can tag @coderabbitai in a PR comment and ask one-off questions about the PR and the codebase. Use quoted replies to pass the context for follow-up questions.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

@strickvl
Copy link
Contributor Author

@coderabbitai review

coderabbitai[bot]
coderabbitai bot reviewed Dec 20, 2023
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: .coderabbit.yaml

Commits Files that changed from the base of the PR and between a662aa2 and 7024f04.
Files selected for processing (18)
  • .github/actions/setup_environment/action.yml (2 hunks)
  • .github/workflows/ci.yml (2 hunks)
  • .github/workflows/codeql.yml (1 hunks)
  • .github/workflows/image-optimiser.yml (1 hunks)
  • .github/workflows/integration-test.yml (4 hunks)
  • .github/workflows/mixpanel-test-data.yml (2 hunks)
  • .github/workflows/pr_labeler.yml (1 hunks)
  • .github/workflows/publish_api_docs.yml (2 hunks)
  • .github/workflows/publish_docker_image.yml (1 hunks)
  • .github/workflows/publish_helm_chart.yml (3 hunks)
  • .github/workflows/publish_to_pypi.yml (1 hunks)
  • .github/workflows/publish_to_pypi_nightly.yml (1 hunks)
  • .github/workflows/release.yml (3 hunks)
  • .github/workflows/replace_api_docs_version (1 hunks)
  • .github/workflows/setup-python-environment.yml (4 hunks)
  • .github/workflows/trivy-zenml-core.yml (1 hunks)
  • .github/workflows/trivy-zenserver.yml (1 hunks)
  • .github/workflows/update-templates-to-examples.yml (7 hunks)
Files skipped from review due to trivial changes (6)
  • .github/workflows/ci.yml
  • .github/workflows/image-optimiser.yml
  • .github/workflows/publish_docker_image.yml
  • .github/workflows/replace_api_docs_version
  • .github/workflows/trivy-zenml-core.yml
  • .github/workflows/trivy-zenserver.yml
Additional comments: 33
.github/actions/setup_environment/action.yml (1)
  • 32-32: Ensure compatibility and check for any breaking changes or migration steps required for the update to actions/[email protected].
.github/workflows/codeql.yml (1)
  • 29-29: Ensure compatibility and check for any breaking changes or migration steps required for the update to actions/[email protected].
.github/workflows/integration-test.yml (4)

  • 120-120: Ensure compatibility and check for any breaking changes or migration steps required for the update to easimon/maximize-build-space@v10.

  • 135-135: Ensure compatibility and check for any breaking changes or migration steps required for the update to actions/[email protected].

  • 241-241: Ensure compatibility and check for any breaking changes or migration steps required for the update to mxschmitt/[email protected].

  • 251-251: Ensure compatibility and check for any breaking changes or migration steps required for the update to mxschmitt/[email protected].

.github/workflows/mixpanel-test-data.yml (2)

  • 17-17: Ensure compatibility and check for any breaking changes or migration steps required for the update to actions/[email protected].

  • 20-20: Ensure compatibility and check for any breaking changes or migration steps required for the update to actions/[email protected].

.github/workflows/pr_labeler.yml (2)

  • 17-17: Ensure compatibility and check for any breaking changes or migration steps required for the update to JulienKode/[email protected].

  • 21-21: Ensure compatibility and check for any breaking changes or migration steps required for the update to TimonVS/[email protected].

.github/workflows/publish_api_docs.yml (1)
  • 22-22: Ensure compatibility and check for any breaking changes or migration steps required for the update to actions/[email protected].
.github/workflows/publish_helm_chart.yml (2)

  • 24-24: Ensure compatibility and check for any breaking changes or migration steps required for the update to actions/[email protected].

  • 47-47: Ensure compatibility and check for any breaking changes or migration steps required for the update to azure/[email protected].

.github/workflows/publish_to_pypi.yml (3)

  • 16-16: Ensure compatibility and check for any breaking changes or migration steps required for the update to actions/[email protected].

  • 23-23: Ensure compatibility and check for any breaking changes or migration steps required for the update to actions/[email protected].

  • 28-28: Ensure compatibility and check for any breaking changes or migration steps required for the update to snok/[email protected].

.github/workflows/publish_to_pypi_nightly.yml (3)

  • 16-16: Ensure compatibility and check for any breaking changes or migration steps required for the update to actions/[email protected].

  • 21-21: Ensure compatibility and check for any breaking changes or migration steps required for the update to actions/[email protected].

  • 26-26: Ensure compatibility and check for any breaking changes or migration steps required for the update to snok/[email protected].

.github/workflows/release.yml (3)

  • 26-26: Ensure compatibility and check for any breaking changes or migration steps required for the update to actions/[email protected].

  • 47-47: Ensure compatibility and check for any breaking changes or migration steps required for the update to actions/[email protected].

  • 62-62: Ensure compatibility and check for any breaking changes or migration steps required for the update to actions/[email protected].

.github/workflows/setup-python-environment.yml (5)

  • 88-88: Ensure compatibility and check for any breaking changes or migration steps required for the update to actions/[email protected].

  • 104-104: Ensure compatibility and check for any breaking changes or migration steps required for the update to mxschmitt/[email protected].

  • 111-111: Ensure compatibility and check for any breaking changes or migration steps required for the update to crate-ci/[email protected].

  • 127-127: Ensure compatibility and check for any breaking changes or migration steps required for the update to gaurav-nelson/[email protected].

  • 155-155: Ensure compatibility and check for any breaking changes or migration steps required for the update to mxschmitt/[email protected].

.github/workflows/update-templates-to-examples.yml (6)

  • 74-74: Ensure compatibility and check for any breaking changes or migration steps required for the update to actions/[email protected].

  • 107-107: Ensure compatibility and check for any breaking changes or migration steps required for the update to actions/[email protected].

  • 154-154: Ensure compatibility and check for any breaking changes or migration steps required for the update to actions/[email protected].

  • 186-186: Ensure compatibility and check for any breaking changes or migration steps required for the update to actions/[email protected].

  • 234-234: Ensure compatibility and check for any breaking changes or migration steps required for the update to actions/[email protected].

  • 267-267: Ensure compatibility and check for any breaking changes or migration steps required for the update to actions/[email protected].

@strickvl strickvl requested a review from safoinme December 21, 2023 10:10
avishniakov
avishniakov approved these changes Dec 22, 2023
View reviewed changes
Copy link
Contributor

@avishniakov avishniakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nitpick, rest good to go!

@strickvl strickvl merged commit 84b3841 into develop Dec 22, 2023
30 of 32 checks passed
@strickvl strickvl deleted the misc/remove-space-saver branch December 22, 2023 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@avishniakov avishniakov avishniakov approved these changes

@safoinme safoinme Awaiting requested review from safoinme

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request internal To filter out internal PRs and issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@strickvl @avishniakov