-
Notifications
You must be signed in to change notification settings - Fork 476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add scarf checker script and CI workflow #2227
Conversation
Important Auto Review SkippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the To trigger a single review, invoke the WalkthroughA new GitHub Actions workflow named "Scarf checker" has been introduced to ensure the presence of Scarf analytics in markdown documentation. The workflow triggers on certain events and runs a script to check and enforce the inclusion of a Scarf image link in the markdown files. Additionally, a Bash script has been added to validate this across documentation files, and updates have been made to various documents to include HTML comments and image tags for Scarf analytics. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit's AI:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
@coderabbitai review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 1
Configuration used: .coderabbit.yaml
Files selected for processing (11)
- .github/workflows/scarf-check.yml (1 hunks)
- docs/book/deploying-zenml/zenml-cloud/user-management.md (1 hunks)
- docs/book/reference/how-do-i.md (1 hunks)
- docs/book/stacks-and-components/custom-solutions/custom-stack-solutions.md (1 hunks)
- docs/book/stacks-and-components/stack-deployment/cloud-stacks/minimal-gcp-stack.md (1 hunks)
- docs/book/user-guide/advanced-guide/best-practices/debug-and-solve-issues.md (1 hunks)
- docs/book/user-guide/advanced-guide/best-practices/handling-dependencies.md (1 hunks)
- docs/book/user-guide/advanced-guide/environment-management/environment-variables.md (1 hunks)
- docs/book/user-guide/advanced-guide/pipelining-features/pipelining-features.md (1 hunks)
- scripts/format.sh (1 hunks)
- scripts/scarf-checker.sh (1 hunks)
Files skipped from review due to trivial changes (7)
- docs/book/deploying-zenml/zenml-cloud/user-management.md
- docs/book/stacks-and-components/custom-solutions/custom-stack-solutions.md
- docs/book/stacks-and-components/stack-deployment/cloud-stacks/minimal-gcp-stack.md
- docs/book/user-guide/advanced-guide/best-practices/debug-and-solve-issues.md
- docs/book/user-guide/advanced-guide/best-practices/handling-dependencies.md
- docs/book/user-guide/advanced-guide/environment-management/environment-variables.md
- docs/book/user-guide/advanced-guide/pipelining-features/pipelining-features.md
Additional comments: 8
.github/workflows/scarf-check.yml (2)
1-8: The workflow is correctly set up to trigger on
workflow_dispatch
and when Markdown files are changed in a pull request. This aligns with the PR objectives.12-12: The condition to run only on non-draft PRs is appropriate to ensure the check is performed before merging. However, it's important to verify that this condition works as expected in the repository's CI environment.
scripts/scarf-checker.sh (3)
1-4: The shebang and search text are set correctly. The search text matches the snippet that needs to be present in the Markdown files.
9-16: The loop correctly finds all Markdown files in the
docs/book
directory, excludingtoc.md
, and checks for the presence of the scarf snippet. The logic is sound and aligns with the PR objectives.18-23: The script exits with a non-zero status if any file is missing the snippet, which is the correct behavior for a CI check. The success message is clear and informative.
scripts/format.sh (2)
- 12-38: > Note: This review was outside the patches, so it was mapped to the patch with the greatest overlap. Original lines [1-14]
The script starts with a shebang and sets flags for debugging and analytics opt-out. It then runs
ruff
for code formatting, which is unrelated to the scarf snippet addition. This part of the script is not directly related to the PR objectives but is part of the formatting process.
- 17-37: The script correctly searches for the specified text in Markdown files within
docs/book
, excludingtoc.md
, and appends the scarf snippet if it is missing. This aligns with the PR objectives and ensures consistency across documentation files.docs/book/reference/how-do-i.md (1)
- 58-61: The HTML comment and image tag for the ZenML Scarf have been added correctly to the Markdown file. This change is consistent with the updates described in the PR objectives and ensures the presence of the tracking snippet.
This pull request adds a scarf checker script and a CI workflow to the repository. The script checks for the presence of a scarf snippet in Markdown files and adds it if it's missing. This ensures consistency across the documentation.
Summary by CodeRabbit
New Features
Documentation
Scripts