fix(server-rest): filters at different hierarchies are not properly combined

[ymc9]

fixes #2020

[coderabbitai]

📝 Walkthrough

Walkthrough

The pull request adjusts the filter-building logic in the REST API by moving the initialization of the currType variable inside a nested loop within the buildFilter method. This change affects the timing of variable assignment relative to item creation without altering the overall algorithm. Additionally, new test cases have been added to the REST API test suite to verify filtering posts by author email and title. No changes were made to the exported or public entities.

Changes

File	Change Summary
packages/server/src/…/index.ts	Adjusted the initialization scope of currType in the buildFilter method.
packages/server/tests/api/…test.ts	Added test cases for filtering posts by author email and title.

Assessment against linked issues

Objective	Addressed	Explanation
Merge multiple filters on the same relationship path and support both dot/bracket notation (#2020)	❌	Changes only adjust variable scope and add tests without implementing merging logic.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8a1289c and 51788b0.

📒 Files selected for processing (2)

• packages/server/src/api/rest/index.ts (1 hunks)
• packages/server/tests/api/rest.test.ts (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (5)

• GitHub Check: build-test (20.x)
• GitHub Check: OSSAR-Scan
• GitHub Check: build-test (20.x)
• GitHub Check: build-test (20.x)
• GitHub Check: Analyze (javascript-typescript)

🔇 Additional comments (2)

packages/server/tests/api/rest.test.ts (1)

636-655: Well-structured test cases for hierarchical filters!

These new test cases appropriately verify that filters at different hierarchies (author email and post title) are correctly combined. Both the positive case (user1@abc.com + Post1) and negative case (user1@abc.com + Post2) are covered, ensuring robust testing of the functionality.

packages/server/src/api/rest/index.ts (1)

1554-1558: Good fix for the hierarchical filter issue.

Moving the initialization of currType = typeInfo inside the loop that processes each filter value ensures that each filter chain starts with the correct root type. This fixes the issue where filters at different hierarchies weren't properly combined because subsequent filter chains were using the type from the previous filter rather than the original root type.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.