-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
module: add security info to module.yml #187
module: add security info to module.yml #187
Conversation
zephyr/module.yml
Outdated
- cpe:2.3:o:google:openthread:2019-12-13:*:*:*:*:*:*:* | ||
- pkg:github/openthread/openthread |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should it be like this instead? feels wrong to put an old version of the CPE, but I also understand that the "new" one probably doesn't "exist" until a CVE is reported against it? not sure if it's ok to basically guess? or maybe just put a wildcard even if that means people might get false positives?)
re pkg
, I think the latest released version that our fork is based off of should be there too but again, not sure
- cpe:2.3:o:google:openthread:2019-12-13:*:*:*:*:*:*:* | |
- pkg:github/openthread/openthread | |
- cpe:2.3:o:google:openthread:2023-07-06:*:*:*:*:*:*:* | |
- pkg:github/openthread/openthread@thread-reference-20230706 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question, I will ask around and see if I can find a good answer...
Like you say it doesn't seem right to either use the wrong version number, or to use a CPE that doesn't "exist" yet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated with your suggestion: the consensus internally is that it's better to specify the correct version number, and downstream users of the info can decide how to handle this if a CPE with this specific version does not exist yet.
23f7f18
to
cea7eaa
Compare
zephyr/module.yml
Outdated
@@ -30,3 +30,7 @@ name: openthread | |||
build: | |||
cmake-ext: True | |||
kconfig-ext: True | |||
security: | |||
external-references: | |||
- cpe:2.3:o:google:openthread:2023-07-06*:*:*:*:*:*:* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- cpe:2.3:o:google:openthread:2023-07-06*:*:*:*:*:*:* | |
- cpe:2.3:o:google:openthread:2023-07-06:*:*:*:*:*:* |
cea7eaa
to
fbc5b5c
Compare
Add CPE and PURL references to module.yml file for use by Zephyr's SPDX generation tool. Signed-off-by: Matt Rodgers <[email protected]>
fbc5b5c
to
a514512
Compare
Updated again as I was missing a |
This should be upstreamed as we follow the upstream branch directly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-1 to prevent fly-by merge
EDIT: no permission though
Will move to upstream repo in a sec |
Add CPE and PURL references to module.yml file for use by Zephyr's SPDX generation tool.
See github issue in Zephyr repo: zephyrproject-rtos/zephyr#53479
The CPE added is the most recent one I could find for openthread in the NIST database: https://nvd.nist.gov/products/cpe/detail/5F57440F-9CB1-4BA2-BD81-FA00F15C8441