Repository navigation
Conversation
The testcase.yaml files in tests/ were missing the "rust" tag in their common section. This caused twister to filter them out when run with "-t rust", preventing hardware-only targets such as tiny2040 from being built. Signed-off-by: David Brown <david.brown@linaro.org>
There was a problem hiding this comment.
🟢 Approval recommended
The seven metadata additions match the intended selection behavior and introduce no identified correctness issues.
No open issues 🎉
What changed in this PR
Makes seven Rust test suites selectable by Twister’s -t rust filter, including hardware-only targets.
Changes:
- Adds
tags: rustto each suite’scommonsection. - Preserves existing platform restrictions and configuration filters.
| File | Description |
|---|---|
| tests/timer/testcase.yaml | Tags timer tests as Rust. |
| tests/time/testcase.yaml | Tags time tests as Rust. |
| tests/drivers/pwm-led/testcase.yaml | Tags PWM LED tests as Rust. |
| tests/drivers/led-strip/testcase.yaml | Tags LED strip tests as Rust. |
| tests/drivers/i2c-target/testcase.yaml | Tags I2C target tests as Rust. |
| tests/drivers/i2c-controller/testcase.yaml | Tags I2C controller tests as Rust. |
| tests/drivers/gpio-async/testcase.yaml | Tags asynchronous GPIO tests as Rust. |
Review effort: Balanced
kurtjd
approved these changes
Oct 19, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
testcase.yamlfiles for the Rust tests undertests/have notags:entryin their
common:section. Twister therefore sees norusttag on them, and arun selected with
-t rustfilters all of these tests out.That hides the hardware-only targets, which are not part of the default qemu
twister run. For example the
tiny2040platforms in the i2c, led-strip andpwm-led tests are never built or exercised by a
-t rustrun.Solution
Add
tags: rustto thecommon:section of the seven Rust tests that aremissing it:
tests/drivers/gpio-asynctests/drivers/i2c-controllertests/drivers/i2c-targettests/drivers/led-striptests/drivers/pwm-ledtests/timetests/timerThese are exactly the
testcase.yamlfiles undertests/that already filter onCONFIG_RUST_SUPPORTEDbut declare no tags, so no other test is affected.