feat(cargo): Set rustc-check-cfg for all config options #92
Conversation
|
@d3zd3z thanks for your work so far on this. May I request a review on this, please? |
There was a problem hiding this comment.
Unfortunately, this only squashes some warnings from this lint, specifically settings that are possible in the current configuration, but are disabled. But configurations that don't apply will not be seen by this and will still generate warnings.
Aside from generating a list of all possible configs from all Kconfig files (including modules that aren't present), I don't really see a way to make this work, which is why my examples have just been suppressing the lint.
|
This is true. |
|
I wonder if we could do something with I'll try to find some time to have a look into this. |
ball-hayden
force-pushed
the
check-cfg
branch
3 times, most recently
from
227220c to
8ba2555
Compare
|
@d3zd3z how do you feel about this as an approach? This seems to work for my project - I'd be interested to know how CI fares. I'm not entirely happy about having an intermediate JSON file, but struggling to think of other options that would produce the complete list we need. |
This squashes lint warnings for config options which are not currently enabled. See https://doc.rust-lang.org/cargo/reference/build-scripts.html\#rustc-check-cfg Signed-off-by: Hayden Ball <[email protected]>
This squashes lint warnings for config options which are not currently enabled.
See https://doc.rust-lang.org/cargo/reference/build-scripts.html\#rustc-check-cfg