zephyr: Specify minimum rust version #94
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To allow the 2024 edition of Rust to be used, one of our macros needs a new syntax, introduced in Rust 1.85 to declare that it is known that the macro expansion is unsafe. This could work without the minimum rust version, as long as the macro isn't used, but is needed for tests, and Rust stable has already moved to 1.86, so it isn't an onerous requirement. Signed-off-by: David Brown <[email protected]>
cfriedt
approved these changes
Apr 25, 2025
teburd
approved these changes
Apr 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To allow the 2024 edition of Rust to be used, one of our macros needs a new syntax, introduced in Rust 1.85 to declare that it is known that the macro expansion is unsafe.
This could work without the minimum rust version, as long as the macro isn't used, but is needed for tests, and Rust stable has already moved to 1.86, so it isn't an onerous requirement.