libc: minimal: Add strtoll() and strtoull() #39612

MeisterBob · 2021-10-21T07:26:03Z

strtoll() and strtoull() are copies of strtol() and strtoul() with types
changed to long long instead of long.

Signed-off-by: Gerhard Jörges [email protected]

stephanosio

Please add the tests for these functions in tests/lib/c_lib.
Need to update the relevant documentation:
https://github.com/zephyrproject-rtos/zephyr/blame/main/doc/guides/portability/posix.rst#L311
Need to remove the local strtoll implementation:

zephyr/samples/net/civetweb/common/src/libc_extensions.c

Line 156 in 21d1ad3

long long strtoll(const char *str, char **endptr, int base)

zephyr/samples/net/civetweb/common/include/libc_extensions.h

Line 29 in 21d1ad3

long long strtoll(const char *str, char **endptr, int base);

MeisterBob · 2021-12-14T09:31:26Z

I was busy in an other project the last weeks, but finally I added tests and documentation and removed stubs from civetweb samples. Also rebased the branch..

MeisterBob · 2021-12-22T08:44:42Z

I stumbled across #16511 by @PiotrZierhoffer. I liek the way he unified the conversion mechanism. The only thing missing in his PR where tests. I would suggest to take the tests I implemented and put them into his PR.

rivimey · 2022-01-20T11:32:48Z

tests/lib/c_lib/src/main.c

+
+	char border1[] = "+18446744073709551615";
+	char border2[] = "-18446744073709551615000";
+	char border3[] = "+18446744073709551619";


Suggest adding a couple more cases here to test a long string of digits but not a large number, and a simply very large number:

border[] = "0x0000000000000000000000000000000000001"; // should pass border[] = "10000000000000000000000000000000000001"; // should fail (too big) border[] = "-10000000000000000000000000000000000001"; // should fail (too big)

added those cases to strtoll and strtoull test.

- strtoll() and strtoull() are copies of strtol() and strtoul() with types changed to long long instead of long. - added tests - added documentation - removed stubs from civetweb sample Signed-off-by: Gerhard Jörges <[email protected]>

tejlmand

lgtm - reapprove

stephanosio

This PR contains the source files that are BSD-4-Clause-UC licensed.

This is different to the usual 3-clause BSD license variants that we have previously accepted into the codebase; in particular, the third clause is likely going to be a problem for the project.

 * 3. All advertising materials mentioning features or use of this software
 *    must display the following acknowledgment:
 *	This product includes software developed by the University of
 *	California, Berkeley and its contributors.

If we are to accept this as is, this needs to go through the board as per the Contribution Guidelines.

The most practical solution would be to replace the strto(u)ll implementation with the one that is more freely licensed (e.g. BSD-2-Clause, BSD-3-Clause, ...).

cc @nashif @carlescufi

MeisterBob · 2022-02-22T12:18:21Z

It's the same license strtol and strtoul are using. If you can point out an implementation that more suitable licensed I would be happy to replace strtol, strtoul, strtoll and strtoull.

stephanosio · 2022-02-22T12:43:38Z

It's the same license strtol and strtoul are using. If you can point out an implementation that more suitable licensed I would be happy to replace strtol, strtoul, strtoll and strtoull.

@MeisterBob You are right. They are indeed BSD-4-Clause-UC (not sure why these did not turn up while grepping ...).

In that case, I assume this license has already been approved by the board. I would like @nashif to give a confirmation though, since those date back to the beginning of the project (maybe before such rules were in place?) ...

carlescufi

I am lookin at adding a few more of those. Can you please move those to a single source file and combine the use of the whitespace trimming so that it is not duplicated for every function?

carlescufi

I am lookin at adding a few more of those. Can you please move those to a single source file and combine the use of the whitespace trimming so that it is not duplicated for every function?

Please ignore this, I will take care of this in a follow-up PR.

de-nordic · 2022-03-18T10:49:34Z

Shouldn't this addition be included into release notes?

carlescufi · 2022-03-18T12:10:10Z

This replaces #43289 for the mesh code, with further additions that I will provide.

carlescufi · 2022-03-18T14:25:38Z

Shouldn't this addition be included into release notes?

Release notes are populated at release time generally, except for API breakage/changes.

carlescufi · 2022-03-18T14:36:35Z

@MeisterBob could you please create an issue as described in the doc to get the inclusion of external code accepted please?

carlescufi · 2022-03-24T10:03:00Z

Approved by the TSC, merging with failing checks:

Coding guidelines: Use of reserved identifiers (this is the C library)
Scancode: Use of a non-Apache license (approved by the TSC)

kestewart · 2022-03-24T13:11:30Z

This is a non-OSI approved license. Per:https://docs.zephyrproject.org/latest/contribute/external.html#external-src-process it's going to need board review.

MeisterBob requested a review from nashif as a code owner October 21, 2021 07:26

github-actions bot added the area: C Library C Standard Library label Oct 21, 2021

zephyrbot added the area: Build System label Oct 21, 2021

zephyrbot requested review from enjiamai, KangJianX, stephanosio and tejlmand October 21, 2021 15:51

zephyrbot assigned stephanosio Oct 21, 2021

tejlmand previously approved these changes Nov 8, 2021

View reviewed changes

stephanosio requested changes Nov 12, 2021

View reviewed changes

MeisterBob force-pushed the strtoll branch from 5cf81e2 to 0e6947e Compare December 14, 2021 09:26

MeisterBob requested review from aescolar and daor-oti as code owners December 14, 2021 09:26

github-actions bot added area: Documentation area: Networking area: Samples Samples area: Tests Issues related to a particular existing or missing test labels Dec 14, 2021

rivimey reviewed Jan 20, 2022

View reviewed changes

MeisterBob force-pushed the strtoll branch from 0e6947e to a9e7baf Compare January 21, 2022 10:44

libc: minimal: Add strtoll() and strtoull()

3514e3d

- strtoll() and strtoull() are copies of strtol() and strtoul() with types changed to long long instead of long. - added tests - added documentation - removed stubs from civetweb sample Signed-off-by: Gerhard Jörges <[email protected]>

MeisterBob force-pushed the strtoll branch from a9e7baf to 3514e3d Compare January 21, 2022 11:49

dleach02 dismissed tejlmand’s stale review via 3514e3d February 11, 2022 16:03

tejlmand approved these changes Feb 22, 2022

View reviewed changes

stephanosio added the Licensing The PR has licensing issues => licensing expert to review label Feb 22, 2022

stephanosio requested changes Feb 22, 2022

View reviewed changes

carlescufi requested changes Mar 18, 2022

View reviewed changes

carlescufi approved these changes Mar 18, 2022

View reviewed changes

stephanosio approved these changes Mar 18, 2022

View reviewed changes

stephanosio added the Release Notes To be mentioned in the release notes label Mar 18, 2022

de-nordic approved these changes Mar 18, 2022

View reviewed changes

nashif added the TSC Topics that need TSC discussion label Mar 18, 2022

MeisterBob mentioned this pull request Mar 21, 2022

add strtoll and strtoull to libc minimal #44005

Closed

nashif removed the TSC Topics that need TSC discussion label Mar 23, 2022

carlescufi merged commit 4fd24a4 into zephyrproject-rtos:main Mar 24, 2022

MeisterBob deleted the strtoll branch April 19, 2022 08:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

libc: minimal: Add strtoll() and strtoull() #39612

libc: minimal: Add strtoll() and strtoull() #39612

MeisterBob commented Oct 21, 2021 •

edited by stephanosio

Loading

stephanosio left a comment

MeisterBob commented Dec 14, 2021

MeisterBob commented Dec 22, 2021

rivimey Jan 20, 2022

MeisterBob Jan 21, 2022

tejlmand left a comment

stephanosio left a comment •

edited

Loading

MeisterBob commented Feb 22, 2022

stephanosio commented Feb 22, 2022

carlescufi left a comment

carlescufi left a comment

de-nordic commented Mar 18, 2022

carlescufi commented Mar 18, 2022

carlescufi commented Mar 18, 2022

carlescufi commented Mar 18, 2022

carlescufi commented Mar 24, 2022

kestewart commented Mar 24, 2022

libc: minimal: Add strtoll() and strtoull() #39612

libc: minimal: Add strtoll() and strtoull() #39612

Conversation

MeisterBob commented Oct 21, 2021 • edited by stephanosio Loading

stephanosio left a comment

Choose a reason for hiding this comment

MeisterBob commented Dec 14, 2021

MeisterBob commented Dec 22, 2021

rivimey Jan 20, 2022

Choose a reason for hiding this comment

MeisterBob Jan 21, 2022

Choose a reason for hiding this comment

tejlmand left a comment

Choose a reason for hiding this comment

stephanosio left a comment • edited Loading

Choose a reason for hiding this comment

MeisterBob commented Feb 22, 2022

stephanosio commented Feb 22, 2022

carlescufi left a comment

Choose a reason for hiding this comment

carlescufi left a comment

Choose a reason for hiding this comment

de-nordic commented Mar 18, 2022

carlescufi commented Mar 18, 2022

carlescufi commented Mar 18, 2022

carlescufi commented Mar 18, 2022

carlescufi commented Mar 24, 2022

kestewart commented Mar 24, 2022

MeisterBob commented Oct 21, 2021 •

edited by stephanosio

Loading

stephanosio left a comment •

edited

Loading