cmake: move host-tool loading from Zephyr-sdk into COMPONENTS #49732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
area: Build System
area: Twister
zephyrbot
requested review from
chen-png,
enjiamai,
galak,
gopiotr,
hakehuang,
jeremybettis and
PerMac
|
Related to this PR zephyrproject-rtos/sdk-ng#555
|
|
@tejlmand This can be rebased |
nordicjm
previously approved these changes
Sep 2, 2022
Move loading of Zephyr-sdk host tools cmake file from Zephyr into Zephyr SDK itself. This allows us to cleanup Zephyr CMake code as well as place the responsibility of checking and loading host tools when available. This removes the need for custom printing as CMake find_package() provides this functionality built-in, as well as ensuring uniform message formatting and general package handling. It further remove the confusing message: > -- Found host-tools: zephyr 0.15.0 (/opt/zephyr-sdk-0.15.0) which is printed even when host tools are not installed. Signed-off-by: Torsten Rasmussen <[email protected]>
tejlmand
force-pushed
the
host_tools_module
branch
from
5256915 to
b7861b9
Compare
tejlmand
added
DNM
|
This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move loading of Zephyr-sdk host tools cmake file from Zephyr into
Zephyr SDK itself.
This allows us to cleanup Zephyr CMake code as well as place the
responsibility of checking and loading host tools when available.
This removes the need for custom printing as CMake find_package()
provides this functionality built-in, as well as ensuring uniform
message formatting and general package handling.
It further remove the confusing message:
Signed-off-by: Torsten Rasmussen [email protected]