ext: lib: encoding: tinycbor: fixup newlib_libc reqirement #6968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This path make logic for enabling float and half-float support positive driven and fix NEWLIB_LIBC selections for these features. Signed-off-by: Andrzej Puzdrowski <[email protected]>
half-FP feature requires <math.h> form newlib_libc. It was include wrongly by default. This path fix conduction for related include directive. Signed-off-by: Andrzej Puzdrowski <[email protected]>
|
cc @vrahane |
|
Changes to ext/lib/encoding/tinycbor/src/compilersupport_p.h should be apply to tinycbor upstream PR (intel/tinycbor#83) once will be approved here. |
Codecov Report
@@ Coverage Diff @@
## master #6968 +/- ##
==========================================
- Coverage 55.63% 55.63% -0.01%
==========================================
Files 462 462
Lines 44567 44567
Branches 8296 8296
==========================================
- Hits 24795 24794 -1
- Misses 16380 16381 +1
Partials 3392 3392
Continue to review full report at Codecov.
|
nashif
approved these changes
Apr 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
half-FP feature requires <math.h> form newlib_libc. It was include wrongly by default. This path fix conduction for related include directive.
This path make logic for enabling float and half-float support positive driven and fix NEWLIB_LIBC selections for these features.
Signed-off-by: Andrzej Puzdrowski [email protected]