Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): only run sec checks once on PRs #3607

Merged
merged 1 commit into from
Feb 28, 2025
Merged

Conversation

gartnera
Copy link
Member

@gartnera gartnera commented Feb 27, 2025

Should only run on push to main branches.

image

Summary by CodeRabbit

  • Chores
    • Optimized automated security checks by adjusting commit triggers to run only on designated development and release branches, while maintaining validations for all pull requests.

@gartnera gartnera added the no-changelog Skip changelog CI check label Feb 27, 2025
@gartnera gartnera requested a review from 0xM3R February 27, 2025 18:54
@gartnera gartnera requested a review from a team as a code owner February 27, 2025 18:54
Copy link
Contributor

coderabbitai bot commented Feb 27, 2025

📝 Walkthrough

Walkthrough

This pull request updates the GitHub Actions workflow configuration for security checks. The event trigger for push events is refined to run only for commits made to the develop branch and branches matching the release/* pattern. The configuration for pull request events remains unchanged.

Changes

File Change Summary
.github/workflows/zetachain-sec-checks.yml Modified push event trigger: now restricted to develop and release/* branches; pull_request trigger remains same.

Sequence Diagram(s)

sequenceDiagram
    participant Dev as Developer
    participant GH as GitHub
    participant WF as Security Checks Workflow

    Dev->>GH: Push commit on any branch
    alt Branch is develop or release/*
        GH->>WF: Trigger workflow
    else Other branch
        Note over GH,WF: No workflow triggered
    end

    Dev->>GH: Create pull request
    GH->>WF: Trigger workflow
Loading

Suggested labels

ci

Suggested reviewers

  • CryptoFewka
  • skosito

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3b6ca1a and c059806.

📒 Files selected for processing (1)
  • .github/workflows/zetachain-sec-checks.yml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (6)
  • GitHub Check: build-zetanode
  • GitHub Check: lint
  • GitHub Check: build-and-test
  • GitHub Check: gosec
  • GitHub Check: build
  • GitHub Check: analyze (go)
🔇 Additional comments (1)
.github/workflows/zetachain-sec-checks.yml (1)

3-9: Refined Event Trigger Configuration Looks Correct

The updated YAML now restricts the push event to only the develop and release/* branches while retaining the pull request triggers without additional filtering. This change aligns well with the PR objective of running security checks only once on PRs. Ensure that this limited push trigger meets your overall CI strategy for non-PR commits.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@gartnera gartnera enabled auto-merge February 27, 2025 18:55
@github-actions github-actions bot added the ci Changes to CI pipeline or github actions label Feb 27, 2025
@gartnera gartnera added this pull request to the merge queue Feb 28, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 28, 2025
@gartnera gartnera added this pull request to the merge queue Feb 28, 2025
Merged via the queue into develop with commit bc7906b Feb 28, 2025
48 of 52 checks passed
@gartnera gartnera deleted the sec-checks-dedup branch February 28, 2025 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Changes to CI pipeline or github actions no-changelog Skip changelog CI check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants