Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make Bitcoin deposit with invalid memo reverting #3615

Merged
merged 13 commits into from
Mar 4, 2025

comment out stable ballot check

13a6802
Select commit
Loading
Failed to load commit list.
Merged

feat: make Bitcoin deposit with invalid memo reverting #3615

comment out stable ballot check
13a6802
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Mar 4, 2025 in 0s

64.56% (+0.02%) compared to 0a4acde

View this Pull Request on Codecov

64.56% (+0.02%) compared to 0a4acde

Details

Codecov Report

Attention: Patch coverage is 99.03846% with 1 line in your changes missing coverage. Please review.

Project coverage is 64.56%. Comparing base (0a4acde) to head (13a6802).
Report is 4 commits behind head on develop.

Files with missing lines Patch % Lines
zetaclient/chains/bitcoin/observer/inbound.go 98.55% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3615      +/-   ##
===========================================
+ Coverage    64.53%   64.56%   +0.02%     
===========================================
  Files          469      469              
  Lines        32694    32772      +78     
===========================================
+ Hits         21099    21159      +60     
- Misses       10635    10648      +13     
- Partials       960      965       +5     
Files with missing lines Coverage Δ
x/crosschain/keeper/cctx_gateway_zevm.go 100.00% <100.00%> (ø)
...hain/keeper/cctx_orchestrator_validate_outbound.go 89.09% <100.00%> (ø)
zetaclient/chains/bitcoin/observer/event.go 93.33% <ø> (-2.80%) ⬇️
zetaclient/chains/bitcoin/observer/inbound.go 52.11% <98.55%> (+21.50%) ⬆️

... and 12 files with indirect coverage changes