fix: return nil instead of error directly

[rustco]

Description

The logic of err not being nil has been processed and returned before, so err must be nil here.

How Has This Been Tested?

• Tested CCTX in localnet
• Tested in development environment
• Go unit tests
• Go integration tests
• Tested via GitHub Actions

Summary by CodeRabbit

• Bug Fixes
  • Adjusted log retrieval responses to consistently indicate successful outcomes when no issues occur.
  • Updated the listener initialization process to reliably communicate successful connection creation without error signals.

[coderabbitai]

📝 Walkthrough

Walkthrough

This pull request updates error handling in two functions. In the Ethereum filters API, the GetLogs method now always returns a nil error, regardless of any error that may have occurred. Similarly, the Listen function in the server utilities returns a nil error on successful listener creation. No modifications to exported or public declarations occurred.

Changes

File(s)	Change Summary
rpc/namespaces/.../api.go, server/util.go	Updated return statements in GetLogs and Listen to return nil instead of a potentially non-nil error on success.

Sequence Diagram(s)

sequenceDiagram
  participant C as Caller
  participant API as PublicFilterAPI
  C->>API: Call GetLogs()
  API-->>C: returnLogs(logs), nil

Loading

sequenceDiagram
  participant C as Caller
  participant S as Listen Function
  C->>S: Call Listen()
  S-->>C: ln, nil

Loading

Possibly related PRs

• fix: remove redundant error in parsing synthetic txs #2962: Involved similar modifications to error handling by ensuring functions return nil for successful outcomes.
• refactor: use a more straightforward return value #3542: Also focused on updating return statements to consistently produce a nil error when operations succeed.

Suggested labels

no-changelog

Suggested reviewers

• lumtis
• fbac
• skosito
• swift1337
• brewmaster012

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0a4acde and d78befc.

📒 Files selected for processing (2)

• rpc/namespaces/ethereum/eth/filters/api.go (1 hunks)
• server/util.go (1 hunks)

🧰 Additional context used

📓 Path-based instructions (1)

`**/*.go`: Review the Go code, point out issues relative to ...

**/*.go: Review the Go code, point out issues relative to principles of clean code, expressiveness, and performance.

• server/util.go
• rpc/namespaces/ethereum/eth/filters/api.go

🔇 Additional comments (2)

rpc/namespaces/ethereum/eth/filters/api.go (1)

614-614: Appropriate error handling adjustment.

The change ensures that the function returns nil explicitly as the error value after successfully retrieving logs, which is more semantically accurate than returning a potentially non-nil error value when the operation has succeeded. This approach provides a clearer contract to callers about the success state of the operation.

server/util.go (1)

138-138: Correct error handling pattern implementation.

The modification ensures the function returns a nil error explicitly when listener creation succeeds, which aligns with Go's idiomatic error handling patterns. This change maintains consistency with the similar modification in the filters API and provides a clear indication to callers that the operation completed successfully.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.