-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove mergequeue failed comment #3621
Conversation
📝 WalkthroughWalkthroughThe pull request removes a section of code from the e2e GitHub workflow that previously constructed a URL for the workflow run and automatically posted a comment on the associated pull request when an end-to-end test failed in the merge queue. The functionality that adds a failure label to the pull request remains unchanged. Changes
Sequence Diagram(s)sequenceDiagram
participant WF as Workflow Engine
participant E2E as E2E Runner
participant GH as GitHub API
WF->>E2E: Trigger e2e tests for merge queue event
E2E-->>WF: e2e test fails
WF->>GH: Add failure label to PR
%% Note: Comment posting with workflowRunUrl has been removed.
Possibly related PRs
Suggested labels
Suggested reviewers
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (6)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This comment is not actually needed since github natively show which status check failed:
I had removed this locally but forgot to push the change.
Related to #3611
Summary by CodeRabbit