Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove mergequeue failed comment #3621

Merged
merged 1 commit into from
Mar 4, 2025
Merged

Conversation

gartnera
Copy link
Member

@gartnera gartnera commented Mar 3, 2025

This comment is not actually needed since github natively show which status check failed:

image

I had removed this locally but forgot to push the change.

Related to #3611

Summary by CodeRabbit

  • Chores
    • Streamlined automated notifications by removing the automatic comment on pull requests after test failures.
    • Continued to use labels to indicate the outcome of end-to-end tests, ensuring clarity without extra commentary.

@gartnera gartnera added the no-changelog Skip changelog CI check label Mar 3, 2025
@gartnera gartnera requested a review from a team as a code owner March 3, 2025 18:53
@gartnera gartnera enabled auto-merge March 3, 2025 18:53
Copy link
Contributor

coderabbitai bot commented Mar 3, 2025

📝 Walkthrough

Walkthrough

The pull request removes a section of code from the e2e GitHub workflow that previously constructed a URL for the workflow run and automatically posted a comment on the associated pull request when an end-to-end test failed in the merge queue. The functionality that adds a failure label to the pull request remains unchanged.

Changes

File Change Summary
.github/workflows/e2e.yml Removed block that constructs workflowRunUrl and calls github.rest.issues.createComment on failure; retained label addition logic.

Sequence Diagram(s)

sequenceDiagram
    participant WF as Workflow Engine
    participant E2E as E2E Runner
    participant GH as GitHub API

    WF->>E2E: Trigger e2e tests for merge queue event
    E2E-->>WF: e2e test fails
    WF->>GH: Add failure label to PR
    %% Note: Comment posting with workflowRunUrl has been removed.
Loading

Possibly related PRs

Suggested labels

ci

Suggested reviewers

  • lumtis
  • julianrubino

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 760c8bb and cb69cb7.

📒 Files selected for processing (1)
  • .github/workflows/e2e.yml (0 hunks)
💤 Files with no reviewable changes (1)
  • .github/workflows/e2e.yml
⏰ Context from checks skipped due to timeout of 90000ms (6)
  • GitHub Check: lint
  • GitHub Check: build-zetanode
  • GitHub Check: build-and-test
  • GitHub Check: gosec
  • GitHub Check: build
  • GitHub Check: analyze (go)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the ci Changes to CI pipeline or github actions label Mar 3, 2025
Copy link
Contributor

@morde08 morde08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gartnera gartnera added this pull request to the merge queue Mar 4, 2025
Merged via the queue into develop with commit 099f8df Mar 4, 2025
50 of 53 checks passed
@gartnera gartnera deleted the e2e-mq-nocomment branch March 4, 2025 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Changes to CI pipeline or github actions no-changelog Skip changelog CI check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants