fix(completions): init emoji once in CAPF setup#569
Merged
Conversation
zevlg
requested changes
Apr 14, 2026
a5f2bec to
bf94b8e
Compare
Owner
|
Merged in, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
re-search-backwardin the emoji CAPF functions usestelega-emoji-candidate-max-lengthas the search bound:When
telega-emoji-candidate-max-lengthis 0 (before init), the bound collapses toend, leaving no range to search backward — so the regex never matches, thewhen-let*falls through, andtelega-emoji-init(previously inside the match block) is never reached.Move the init call to
telega-completions-setup-capf, where it runs once at chat buffer setup time, only when an emoji CAPF function is present intelega-completions-capf-functions.Test plan