Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simd: prevent SIGILL with armv6 #184

Merged
merged 1 commit into from
Aug 20, 2023
Merged

simd: prevent SIGILL with armv6 #184

merged 1 commit into from
Aug 20, 2023

Conversation

carenas
Copy link
Contributor

@carenas carenas commented Aug 20, 2023

NEON was introduced as an optional feature with armv7, so disable it for earlier versions.

NEON was introduced as an optional feature with armv7, so disable
it for earlier versions.
Copy link
Owner

@zherczeg zherczeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zherczeg zherczeg merged commit 0821be0 into zherczeg:master Aug 20, 2023
@carenas carenas deleted the simd branch August 20, 2023 04:56
@zherczeg
Copy link
Owner

There should be some compiler define for NEON.

@carenas
Copy link
Contributor Author

carenas commented Aug 20, 2023

there is as shown in #144, but almost all popular armv7 (except maybe tegra 2) in use include support even if optional

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants