[milvus] Fix missing clusterDomain in config template #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Welcome @chino540off! It looks like this is your first PR to zilliztech/milvus-helm 🎉 |
chino540off
force-pushed
the
missing-etcd-clusterDomain
branch
2 times, most recently
from
e98fc4f to
c102841
Compare
chino540off
changed the title
chino540off
force-pushed
the
missing-etcd-clusterDomain
branch
from
61fcfc4 to
f82f520
Compare
|
@chino540off good catch! also applies to milvus-operator |
haorenfsa
requested changes
Oct 29, 2024
haorenfsa
reviewed
Oct 29, 2024
Signed-off-by: Olivier Détour <[email protected]>
Signed-off-by: Olivier Détour <[email protected]>
chino540off
force-pushed
the
missing-etcd-clusterDomain
branch
from
f82f520 to
c711316
Compare
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chino540off, haorenfsa The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes missing clusterDomain setting in etcd configuration.
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[mychartname])