Conversation
|
|
||
| You can run `cargo make help` for a list of commands available. | ||
|
|
||
| `cargo make compute-image tag` |
There was a problem hiding this comment.
typo: missing "-" between "image" and "tag". Not a big deal, but if people copy and run int, it wont work
| using `./utils/get-ci-image-tag.sh`, formats what's found in the checked-in `.env.testing-artifacts` file (based on commits of `zcahsd`, `zebrad`, and Rust version) into a docker image tag, prints them to stdout and makes the CARGO_MAKE_IMAGE_TAG environment variable. | ||
|
|
||
| `cargo make test` | ||
| Runs integration tests in a docker container, defined from `Dockerfile.ci`, and mounts the local Zaino directory on the host system. |
There was a problem hiding this comment.
Wording is a bit off here (i think). I would say the volumes are mounted on the container.
Also, maybe listing all the volumes would be good? it mounts the zaino source code (the repo clone), the target directory and a .cargo that isn't the global one, but a dedicated location to avoid messing with your global cargo stuff.
There was a problem hiding this comment.
I would also explain the flow followed by this command to get your image:
- it gets the image tag described in
cargo make compute-image-tag - it checks if the local docker daemon has that image available
- if not, it tries to pull the image from Dockerhub
- if not available there either, it builds it (using the
build-image) task - after all that (or just some of that, if any step finds the image already), it runs:
cargo nextest run --profile ciUser can pass in extra arguments too, for example
cargo make test zebrad::get::addresswill result in the container running
cargo nextest run --profile ci zebrad::get::address|
|
||
| `base-script` | ||
| sources `helpers.sh` | ||
| runs tests with appropriate image, |
There was a problem hiding this comment.
i would'nt say that base script runs tests. It just sources the helpers and computes the TAG
|
This current setup is a bit limiting since it only makes it easy to do |
|
Because the |
|
I think this PR has likely been superceded. Is it still providing relevant documentation @ala-mode ? |
WIP, cargo-make documentation