Ciptbz by diagram 6#825
Merged
fluidvanadium merged 4 commits intochainindex_passthrough_behind_zebrafrom Feb 16, 2026
Merged
Conversation
fluidvanadium
force-pushed
the
ciptbz_by_diagram_6
branch
from
fd18805 to
f0ab0b0
Compare
AloeareV
reviewed
Feb 13, 2026
| if start <= max_servable_height.min(end) { | ||
| Some( | ||
| futures::stream::iter((start.0)..=(end.0)).then(move |height| async move { | ||
| // For blocks above validator_finalized_height, it's not reorg-safe to get blocks by height. It is reorg-safe to get blocks by hash. What we need to do in this case is use our snapshot index to look up the hash at a given height, and then get that hash from the validator. |
Contributor
There was a problem hiding this comment.
This is true, but is probably better served as a comment on line 786 (Ok(None)) => match ...). This line is getting heights from the finalized state.
Contributor
There was a problem hiding this comment.
In fact, this line might be unnecessarily complex...we should be able to trust any finalized blocks zebra serves us without having to check the finalized state at all..but for that I'd prefer to just...land passthrough, and open an issue for a follow-up simplification, at this point.
AloeareV
approved these changes
Feb 13, 2026
Contributor
AloeareV
left a comment
AloeareV
left a comment
There was a problem hiding this comment.
There's a comment that I think would be clearer in a different place. Not sure if this is a blocking concern, I'll leave that up to you.
fluidvanadium
force-pushed
the
ciptbz_by_diagram_6
branch
from
f0ab0b0 to
fb7bcc8
Compare
fluidvanadium
force-pushed
the
ciptbz_by_diagram_6
branch
from
fb7bcc8 to
a0e7eaf
Compare
…a' into ciptbz_by_diagram_7
fluidvanadium
merged commit 6bc3bb8
into
chainindex_passthrough_behind_zebra
10 of 11 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: comments only