Remove inconsistent method #1179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
zancas
added
the
lower priority
Oscar-Pepper
requested changes
Jun 3, 2024
Oscar-Pepper
previously approved these changes
Jun 3, 2024
zancas
dismissed
Oscar-Pepper’s stale review
The merge-base changed after approval.
zancas
force-pushed
the
remove_inconsistent_method
branch
from
0564619 to
3e29765
Compare
Co-authored-by: oscar-pepper <[email protected]> Signed-off-by: Za Wilcox <[email protected]>
zancas
force-pushed
the
remove_inconsistent_method
branch
from
3e29765 to
5575045
Compare
zancas
added
TOP PRIORITY
|
Local test pass, please see chat. |
|
Based on previous approval without code change, and passing all local tests, I am merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #1178