Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove zip317 gate #1184

Closed
wants to merge 11 commits into from
Closed

Remove zip317 gate #1184

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
888fd63
zingolib tests pass after removing zip317 feature gate
zancas Jun 2, 2024
f969445
update commands.rs to remove references to zip317 gate
zancas Jun 2, 2024
dae8e77
remove parse shield args utility
zancas Jun 2, 2024
23c9082
remove (temporarily?) unused variants
zancas Jun 2, 2024
83f9af8
Merge remote-tracking branch 'zancas/fix_is_outgoing_double_count_bug…
zancas Jun 2, 2024
f393813
define old_send to wrap quick_send, but support old send interface fo…
zancas Jun 2, 2024
63768dc
finish test shim
zancas Jun 2, 2024
7a1dd05
no new test failures when this unused code is deleted
zancas Jun 2, 2024
622d4ea
make testutils from_inputs::shield wrap quick_shield
zancas Jun 3, 2024
86f7522
remove do_shield and verify that cargo nextest run -p zingolib passes…
zancas Jun 3, 2024
f50cb68
Merge branch 'dev' into remove_zip317_gate
zancas Jun 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion darkside-tests/src/utils.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -679,7 +679,7 @@ pub mod scenarios {
DarksideSender::IndexedClient(n) => self.get_lightclient(n),
DarksideSender::ExternalClient(lc) => lc,
};
zingo_testutils::lightclient::from_inputs::send(
zingo_testutils::lightclient::from_inputs::old_send(
lightclient,
vec![(receiver_address, value, None)],
)
Expand Down
21 changes: 12 additions & 9 deletions darkside-tests/tests/advanced_reorg_tests.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -557,9 +557,10 @@ async fn reorg_changes_outgoing_tx_height() {

// Send 100000 zatoshi to some address
let amount: u64 = 100000;
let sent_tx_id = from_inputs::send(&light_client, [(recipient_string, amount, None)].to_vec())
.await
.unwrap();
let sent_tx_id =
from_inputs::old_send(&light_client, [(recipient_string, amount, None)].to_vec())
.await
.unwrap();

println!("SENT TX ID: {:?}", sent_tx_id);

Expand Down Expand Up @@ -795,9 +796,10 @@ async fn reorg_expires_outgoing_tx_height() {

// Send 100000 zatoshi to some address
let amount: u64 = 100000;
let sent_tx_id = from_inputs::send(&light_client, [(recipient_string, amount, None)].to_vec())
.await
.unwrap();
let sent_tx_id =
from_inputs::old_send(&light_client, [(recipient_string, amount, None)].to_vec())
.await
.unwrap();

println!("SENT TX ID: {:?}", sent_tx_id);

Expand Down Expand Up @@ -975,9 +977,10 @@ async fn reorg_changes_outgoing_tx_index() {

// Send 100000 zatoshi to some address
let amount: u64 = 100000;
let sent_tx_id = from_inputs::send(&light_client, [(recipient_string, amount, None)].to_vec())
.await
.unwrap();
let sent_tx_id =
from_inputs::old_send(&light_client, [(recipient_string, amount, None)].to_vec())
.await
.unwrap();

println!("SENT TX ID: {:?}", sent_tx_id);

Expand Down
Loading
Loading