Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handle invalid txid errors #1659

Merged
merged 3 commits into from
Feb 17, 2025
Merged

handle invalid txid errors #1659

merged 3 commits into from
Feb 17, 2025

Conversation

Oscar-Pepper
Copy link
Contributor

handles user facing panic where server rejects a transaction and returns error string that is not hex decodable

fluidvanadium
fluidvanadium approved these changes Feb 17, 2025
View reviewed changes
Copy link
Contributor

@fluidvanadium fluidvanadium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good. I don't know what the deal is with the features, maybe its worth me looking into.

@fluidvanadium fluidvanadium merged commit 6f29b9f into zingolabs:stable Feb 17, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fluidvanadium fluidvanadium fluidvanadium approved these changes

@zancas zancas Awaiting requested review from zancas

@juanky201271 juanky201271 Awaiting requested review from juanky201271

@AloeareV AloeareV Awaiting requested review from AloeareV

@dorianvp dorianvp Awaiting requested review from dorianvp

@idky137 idky137 Awaiting requested review from idky137

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Oscar-Pepper @fluidvanadium