Impl inp src for trbid #963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the assemble method to take the new versions of its components.
Iisft fixup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@fluidvanadium I think this is the minimal functionality needed to get the input source implementation working (the commit history is wild enough that I'd consider some sort of rebase-like git commit cleanup, but the changes that actually made it to the diff are the right ones). Maybe the helper functions should be in a precurser pr...but they'd be temporarily dead code.
@zancas You were asking about unit tests, these input_source functions all need unit tests...I was trying to write a unit test for get_spendable_transparent_output recently and was blocked on it. #957 probably wants to land before those unit tests, iiuc you're working on getting that one working with the explicit default branch you mentioned to me somewhere?
@Myself, this pr is still draft because get_spendable_transparent_notes (with an s) is still todoed, I'm hoping to get that done tomorrow and undraft this.