Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wallet read part 1 #966

Closed
wants to merge 5 commits into from
Closed

Wallet read part 1 #966

wants to merge 5 commits into from

Conversation

fluidvanadium
Copy link
Contributor

this implements part of WalletRead on TxMapAndMaybeTrees

@zancas
Copy link
Member

zancas commented Apr 20, 2024

OK here's my thought... you're basically interfacing with the lrz "Account" idea.

In order to do so, you need to add a bunch of new dependencies.

I propose a whole new crate: zingo-account with all the new functionality contained inside. Then it can have lots of separation of concern, encapsulation, modularization, etc. What say you?

zancas
zancas reviewed Apr 20, 2024
View reviewed changes
Copy link
Member

@zancas zancas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I propose breaking ZingoAccount into a micro-crate.

@fluidvanadium fluidvanadium marked this pull request as draft April 23, 2024 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zancas zancas zancas requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fluidvanadium @zancas