fix rust 2024 breakage with cargo v1 action#144
Merged
Pr0methean merged 1 commit intozip-rs:masterfrom May 22, 2024
Merged
Conversation
Member
|
The Rust source says the current behavior is actually to implicitly borrow the slice and call |
Member
|
The upstream discussion is here: |
Member
|
The reason for the old behavior AFAICT was so that e.g. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
masteris broken, seemingly by a change in thecargoaction: https://github.com/zip-rs/zip2/actions/runs/9185032790/job/25258374442This is breaking CI on other PRs. I believe this change produces the correct behavior. We could also simply change to
.iter(), but this PR retains the current behavior of consuming the boxed slice.