feat: add builtin command ZkNewFromTitleAndContentSelection
#210
+33
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NickvanDyke
commented
Feb 19, 2025
| local selected_text = util.get_selected_text() | ||
| assert(selected_text ~= nil, "No selected text") | ||
|
|
||
| local title, content = selected_text:match("%W*([^\n]+)\n+(.+)$") |
There was a problem hiding this comment.
I'm a Lua newbie, there might be a better way to write this pattern. It has worked for me but may miss edge cases that my workflow doesn't hit.
NickvanDyke
commented
Feb 19, 2025
| assert(title ~= nil and content ~= nil, "No newline-delimited title and content found in selection") | ||
|
|
||
| options = options or {} | ||
| options.title = vim.fn.input("Title: ", title) |
There was a problem hiding this comment.
I wanted the ability to edit the extracted title. I know this is different from how the other commands pass { title = vim.fn.input('<user-chosen-prompt>') } rather than have the command do it internally. I considered a callback in options but thought that might be even less consistent. Let me know what you'd prefer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm enjoying the plugin and appreciate the builtin commands
ZkNewFromContentSelectionandZkNewFromTitleSelectionto refactor and atomize growing notes. However the section I wish to extract frequently already has a markdown heading, e.g.So I wrote a new command that will extract the selection's first line as the title (ignoring any starting non-characters like
#and-), and the rest as the content. I think it complements the aforementioned builtins nicely and imagine I'm not the only one with this workflow, hence the PR. Feel free to disagree :)