fix(keymap): Replace some keypad keycodes

[TheTuxis]

This change fixes the key mapping for the coner keyboard in the raise_layer.

The previous configuration works only for keyboards with an English layout, with this change it works in all languages.

[lesshonor]

The previous configuration works only for keyboards with an English layout, with this change it works in all languages.

This is definitely incorrect...but using a shifted keycode instead of a keypad keycode is at least more consistent with all the other punctuation on this layer, so it gets my vote.

[TheTuxis]

Thank @lesshonor, I tried the original configuration in Spanish and the problem was that it strictly uses the *, however with the current configuration it considers shift + 8.

[caksoylar]

How about fixing this in other default keymaps as well? I see the same issue for:

• microdox
• splitkb_aurora_corne
• lily58
• sofle
• iris
• corneish_zen

[TheTuxis]

How about fixing this in other default keymaps as well? I see the same issue for:

• microdox
• splitkb_aurora_corne
• lily58
• sofle
• iris
• corneish_zen

Do you want me to include it in the same PR?

[caksoylar]

I think that would be appropriate, if you update the PR name accordingly.

[TheTuxis]

I think that would be appropriate, if you update the PR name accordingly.

I already changed them in corne, microdox, iris and splitkb_aurora_corne.

In lily58 and sofle it would not correspond because the character that is represented is strictly the *, not shift + 8.

Note: I didn't find the corneish_zen keymap, will you use any of the others?

[caksoylar]

Re: lily58 and sofle, I mean e.g. this KP_MULTIPLY and KP_PLUS which don't seem to belong there, since they aren't near the other keypad keycodes. You can see they are fixed in the splitkb variants already.

Here is the corneish_zen one: https://github.com/zmkfirmware/zmk/blob/main/app/boards/arm/corneish_zen/corneish_zen.keymap#L61C80-L61C92

For the PR title, something like "fix(keymap): Replace some keypad keycodes" might be generic and informative enough to cover these changes.

[TheTuxis]

All complete suggestions

[caksoylar]

LGTM, thanks.

[TheTuxis]

@caksoylar @lesshonor
I don't have permission to merge the pr, do I have to do something else?

[caksoylar]

No, one of the core contributors will need to have a look and merge.

[petejohanson]

Thanks!