Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove/replace deprecated properties #2104

Merged
merged 2 commits into from
Mar 18, 2024

Conversation

lesshonor
Copy link
Contributor

@lesshonor lesshonor commented Jan 9, 2024

A few overlays scattered across boards, shields and tests appear to have been missed when updating/upgrading these properties.

Tagging @ReFil who may or may not be crbn's maintainer: resolution was replaced with sane defaults for steps and triggers-per-rotation, but I am unfamiliar with this shield. If there are specific known values that should go here, please suggest. Handled in #2143.

@lesshonor lesshonor requested a review from a team as a code owner January 9, 2024 16:35
@lesshonor lesshonor changed the title refactor: remove/eplace deprecated properties refactor: remove/replace deprecated properties Jan 9, 2024
* The underscore form of this property is deprecated.
* The underscore form of this property is deprecated.
Copy link
Contributor

@petejohanson petejohanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@petejohanson petejohanson merged commit 6f2e19f into zmkfirmware:main Mar 18, 2024
55 checks passed
@lesshonor lesshonor deleted the cleanup/properties branch June 24, 2024 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants