-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(split): add peripheral changed event on central #2741
Open
ReFil
wants to merge
1
commit into
zmkfirmware:main
Choose a base branch
from
ReFil:peripheral_status_changed
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petejohanson
requested changes
Jan 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this! A few thoughts.
app/CMakeLists.txt
Outdated
Comment on lines
98
to
101
if (CONFIG_ZMK_SPLIT AND (NOT CONFIG_ZMK_SPLIT_ROLE_CENTRAL)) | ||
target_sources(app PRIVATE src/events/split_peripheral_status_changed.c) | ||
endif() | ||
target_sources_ifdef(CONFIG_ZMK_SPLIT_ROLE_CENTRAL app PRIVATE src/events/split_central_peripheral_status_changed.c) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Honestly, it'd be clearer if using just conditional branches for both, IMHO:
Suggested change
if (CONFIG_ZMK_SPLIT AND (NOT CONFIG_ZMK_SPLIT_ROLE_CENTRAL)) | |
target_sources(app PRIVATE src/events/split_peripheral_status_changed.c) | |
endif() | |
target_sources_ifdef(CONFIG_ZMK_SPLIT_ROLE_CENTRAL app PRIVATE src/events/split_central_peripheral_status_changed.c) | |
if (CONFIG_ZMK_SPLIT) | |
if(CONFIG_ZMK_SPLIT_ROLE_CENTRAL) | |
target_sources(app PRIVATE src/events/split_central_peripheral_status_changed.c) | |
else() | |
target_sources(app PRIVATE src/events/split_peripheral_status_changed.c) | |
endif() | |
endif() |
1d433f6
to
dff7aaf
Compare
Add a new event for when any peripheral connects or disconnects from the central
dff7aaf
to
1a0b051
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new event for when any peripheral connects or disconnects from the central
PR check-list