Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pointing): Allow input processor aborting before sending to central #2844

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

badjeff
Copy link

@badjeff badjeff commented Feb 27, 2025

Add exit point in input processor loop on split input. That allow aborting the chain of processing before sending event to central from split peripheral.

Two ZIP modules had been designed with this change, that reduce BT loading between peripherals and central (mostly, at dongle mode)

PR check-list

  • Branch has a clean commit history
  • Additional tests are included, if changing behaviors/core code that is testable.
  • Proper Copyright + License headers added to applicable files (Generally, we stick to "The ZMK Contributors" for copyrights to help avoid churn when files get edited)
  • Pre-commit used to check formatting of files, commit messages, etc.
  • Includes any necessary documentation changes.

@badjeff badjeff requested a review from a team as a code owner February 27, 2025 00:29
@caksoylar caksoylar added core Core functionality/behavior of ZMK pointers Pointer related functionality labels Feb 27, 2025
Copy link
Contributor

@petejohanson petejohanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! A comment on the implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core functionality/behavior of ZMK pointers Pointer related functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants