Display an error when trying to add an user with a non-localhost IP #889
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
When trying to call
add_api_user
from a non-localhost IP, no error message is sent to the client, nor logged. This emits an error message using the custom error handling from #847.Context
Emit an error when calling
add_api_user
from a remote IP.Changes
Update the
add_api_user
method and update the API documentation with an output example.How to test this PR
Calling the
add_api_user
from a remote IP should send back an error message. For instancecurl -s "Content-Type: application/json" --data '{"method":"add_api_user","params:{"username":"toto","api_key":"toto"},"id":1,"jsonrpc":"2.0"}' http://10.0.0.1:5000/ | jq
should return something like