-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Installation instructions for CentOS 7 #1080
Conversation
With support for DNSSEC algos 15 and 16, installing openssl11-devel from EPEL repositories.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested by installing Zonemaster CLI on containerized Centos 7 and running zonemaster-cli --no-ipv6 --test DNSSEC --level info ed25519.nl
, working fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will update zonemaster/zonemaster#1060 to match the fact that algo 15 and 16 are supported.
### Installation on CentOS 7 | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add something like
Please note! CentOS 7 will only be supported until the release of v2023.1, which is expected to happen during the spring of 2023. Consider Rocky Linux for an alternative Red Hat Linux derivative.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe also encourage people to let us know what they're migrating to? Now, I don't expect anyone to actually make an effort to tell us. But I think it's good thing PR-wise to give people a feeling that we care about how they're using Zonemaster.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried to address both comments.
docs/Installation.md
Outdated
sudo cpanm Module::Install::XSUtil MooseX::Singleton | ||
``` | ||
|
||
4) Install Zonemaster::LDNS with DNSSEC 15 and 16 support: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DNSSEC 15 and 16
-> DNSSEC algorithm 15 and 16
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Install Zonemaster::LDNS with support for DNSKEY algorithms 15 and 16
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Purpose
This reinstates installation instructions for CentOS 7 but with support for DNSSEC algos 15 and 16.
Context
based on zonemaster/zonemaster-ldns#134
Changes
New section for CentOS 7 in installation document with specific instruction to install Zonemaster::LDNS.
How to test this PR
Following the installation instruction should result in a properly working Zonemaster instance with support for DNSSEC algo 15 and 16.