Update obsolete unit test #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge master into develop (Zonemaster-LDNS)
marc-vanderwal
requested review from
mattias-p,
matsduf,
tgreenx and
MichaelTimbert
Running make test with TEST_WITH_NETWORK=1 in the environment fails because the mail exchange (MX) records for iis.se were changed. Now, it’s a single record of preference 0 pointing to something within the “microsoft” TLD. I tried to retain the spirit of the original test by picking another domain with 2 MX records with non-zero preference values and whose MX records have a reasonable expectation of stability.
marc-vanderwal
force-pushed
the
update-obsolete-unit-test
branch
from
1ac9085 to
2d45e56
Compare
tgreenx
previously approved these changes
Jan 29, 2025
tgreenx
added
the
V-Patch
Merged
matsduf
previously approved these changes
Mar 12, 2025
marc-vanderwal
dismissed stale reviews from matsduf and tgreenx
The base branch was changed.
|
Changing base branch, because we set the milestone to v2024.2.2. Can I have new approvals please? 🙂 |
mattias-p
approved these changes
Mar 13, 2025
matsduf
approved these changes
Mar 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR updates a unit test in Zonemaster-LDNS made obsolete by a change in the MX resource record set of
iis.se. As a consequence, runningTEST_WITH_NETWORK=1 make testalways failed.I tried to retain the spirit of the original test by picking another domain with 2 MX records with non-zero preference values and whose MX records have a reasonable expectation of stability.
Context
Preparation of #217.
Changes
zonemaster.frinstead ofiis.se.How to test this PR
Run
TEST_WITH_NETWORK=1 make test. Unit tests should pass.