fix: Fix error when Plone site is not yet set as in first index_html call

[bsuttor]

In first index_html call on Zope, for example on http://localhost:8080/index_html, REQUEST for Plone Site is not yet set.
If you go directly on Plone, for example on http://localhost:8080/Plone/index_html, request is set to Plone Site (by acquisition) and you have not this error.

    ...
    z3c.jbot-2.0-py3.10.egg/z3c/jbot/utility.py", line 27, in getRequest
    return site.REQUEST
AttributeError: REQUEST

This fix is only usefull for first call on http://localhost:8080/index_html

[icemac]

This code always calls Zope2.app().REQUEST but it only seems to be needed in rare cases. I'd suggest to refactor this line, so Zope2.app().REQUEST is only computed when actually needed.

[d-maurer]

Michael Howitz wrote at 2024-11-27 23:28 -0800:

@icemac commented on this pull request. > @@ -24,7 +25,7 @@ def getRequest(): try: return site.request except AttributeError: - return site.REQUEST + return getattr(site, "REQUEST", Zope2.app().REQUEST) This code always calls `Zope2.app().REQUEST` but it only seems to be needed in rare cases. I'd suggest to refactor this line, so `Zope2.app().REQUEST` is only computed when actually needed.

In addition: `Zope2.app().REQUEST` will not return a request object but `'<Special Object Used to Force Acquisition>'` (i.e. `Acquisition.Acquired`). It is unlikely that this is a good return value for `getRequest`. Maybe, `None` will do instead.

[bsuttor]

So Im' going to test "return None" instead of "return getattr(site, "REQUEST", Zope2.app().REQUEST)" on my use case. And if I haven't any errors I will change my PR

[d-maurer]

Benoît Suttor wrote at 2024-11-28 00:53 -0800:

So Im' going to test "return None" instead of "return getattr(site, "REQUEST", Zope2.app().REQUEST)" on my use case. And if I haven't any errors I will change my PR

What about `return getattr(site, "REQUEST", None)`?

[bsuttor]

What about return getattr(site, "REQUEST", None)?

Indeed, lot better

[coveralls]

Pull Request Test Coverage Report for Build 12069008348

Details

• 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage decreased (-0.2%) to 82.456%

---

Totals
Change from base Build 10028163829:	-0.2%
Covered Lines:	350
Relevant Lines:	409

---

💛 - Coveralls

[icemac]

Just released in https://pypi.org/project/z3c.jbot/2.1/.