Skip to content

Conversation

@icemac
Copy link
Member

@icemac icemac commented Apr 9, 2025

  • Bumped version for breaking release.
  • Replace pkg_resources namespace with PEP 420 native namespace.
  • Switch to PEP 420 native namespace.

@icemac
Copy link
Member Author

icemac commented Apr 9, 2025

It seems that the tests require a new release of z3c.objpath with native namespace support to succeed.

@ale-rt
Copy link
Member

ale-rt commented Apr 10, 2025

It seems that the tests require a new release of z3c.objpath with native namespace support to succeed.

PR ready zopefoundation/z3c.objpath#13

@icemac
Copy link
Member Author

icemac commented Apr 14, 2025

After requiring a z3c.objpath version which uses PEP 420 native namespaces the next problem is:

  • the xml extra depends on z3c.schema2xml – this package is archived since 2020 and only Martijn Faassen has the rights to release it.

@mauritsvanrees @ale-rt Is this extra still used in the Plone world or can we drop it?

@ale-rt
Copy link
Member

ale-rt commented Apr 14, 2025

@ale-rt
Copy link
Member

ale-rt commented Apr 14, 2025

Does it make sense to drop the [xml] extra?
That is not used by Plone.

`z3c.schema2xml` is unmaintained for years now.
@icemac
Copy link
Member Author

icemac commented Apr 15, 2025

@ale-rt I dropped the xml extra, could you please review?

@coveralls
Copy link

Pull Request Test Coverage Report for Build 14463256295

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+7.9%) to 92.593%

Totals Coverage Status
Change from base Build 14114610201: 7.9%
Covered Lines: 365
Relevant Lines: 389

💛 - Coveralls

Copy link
Member

@ale-rt ale-rt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@icemac icemac merged commit 06bbaf1 into master Apr 16, 2025
11 checks passed
@icemac icemac deleted the pep-420-native-namespace branch April 16, 2025 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants