Fix help text and error IDs for aria-describedby #746
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xi
force-pushed
the
fix-error-aria-describedby
branch
from
53ea6b5 to
dba5fc0
Compare
Django recently started using `aria-describedby` to associate form fields first with their help texts, and later also with error messages. In zostera#716, django-bootstrap5 was adapted to also include those the necessary IDs in templates. `aria-describedby` for fields can have different values: - `"{field.auto_id}_helptext"` - `"{field.auto_id}_error"` - both of them - a user defined value that is left unchanged The approach in zostera#716 was to use the value from `aria-describedby` for the ID of the help text. Unfortunately, this only works in the first case. So I propose to solve this the same way the django templates solve this and just hardcode the IDs.
xi
force-pushed
the
fix-error-aria-describedby
branch
from
dba5fc0 to
2e5b167
Compare
xi
force-pushed
the
fix-error-aria-describedby
branch
from
1e844e1 to
9f3fbe2
Compare
|
Python 3.9 / Django 4.2 triggers an error, can you check that? |
|
Done. I am a bit confused why the other 4.2 tests environments didn't fail, but it seems to work now. |
dyve
approved these changes
May 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Django recently started using
aria-describedbyto associate form fields first with their help texts, and later also with error messages.In #716, django-bootstrap5 was adapted to also include those the necessary IDs in templates.
aria-describedbyfor fields can have different values:"{field.auto_id}_helptext""{field.auto_id}_error"The approach in #716 was to use the value from
aria-describedbyfor the ID of the help text. Unfortunately, this only works in the first case.So I propose to solve this the same way the django templates solve this and just hardcode the IDs.