Skip to content

Fix last read date deletion crash#1275

Merged
mvasilak merged 5 commits intozotero:masterfrom
mvasilak:fix-last-read-date-deletion-crash
Apr 23, 2026
Merged

Fix last read date deletion crash#1275
mvasilak merged 5 commits intozotero:masterfrom
mvasilak:fix-last-read-date-deletion-crash

Conversation

@mvasilak
Copy link
Copy Markdown
Contributor

@mvasilak mvasilak requested a review from michalrentka April 18, 2026 09:09
@mvasilak mvasilak force-pushed the fix-last-read-date-deletion-crash branch from 2c9543a to 8cf411b Compare April 20, 2026 13:02
@mvasilak mvasilak requested a review from michalrentka April 20, 2026 13:04
@michalrentka
Copy link
Copy Markdown
Contributor

Added some comments how to slightly improve the code. Though the issue lies in a different place, looks like the faulty setting is lastReadAloudPosition_u_R2NCC4YU, not lastRead. So the issue lies in detecting the setting type :). But we can keep the code, it won't hurt to have proper checks here too.

But please make sure to fix the actual issue too.

Comment thread Zotero/Controllers/Database/Requests/PerformDeletionsDbRequest.swift Outdated
Comment thread Zotero/Controllers/Sync/SyncActions/PerformDeletionsSyncAction.swift Outdated
@mvasilak mvasilak force-pushed the fix-last-read-date-deletion-crash branch from 8cf411b to 5c77bd1 Compare April 20, 2026 20:56
@mvasilak mvasilak requested a review from michalrentka April 20, 2026 21:00
@mvasilak mvasilak merged commit 6b815e4 into zotero:master Apr 23, 2026
1 check passed
@mvasilak mvasilak deleted the fix-last-read-date-deletion-crash branch April 23, 2026 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants