Skip to content

autocomplete: Sort user-mention autocomplete results #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
chrisbobbe opened this issue Jul 19, 2023 · 5 comments · Fixed by #849
Closed

autocomplete: Sort user-mention autocomplete results #228

chrisbobbe opened this issue Jul 19, 2023 · 5 comments · Fixed by #849
Assignees
@sm-sayedi
Labels
a-compose Compose box, autocomplete, attaching files/images
Milestone
M3: Summer 2024

Comments

@chrisbobbe
Copy link
Collaborator

Perhaps by name, to start with, but really:

#207 (review)

(Or better yet something more relevant than name: some kind of relevance to search plus relevance to the context, like people subscribed to the stream or that have talked recently in the narrow. But sorting by user ID seems like it's just going to feel weird and arbitrary to people.)
@chrisbobbe chrisbobbe mentioned this issue Jul 19, 2023
Merged
@gnprice gnprice added the a-compose Compose box, autocomplete, attaching files/images label Jul 19, 2023
@gnprice gnprice added this to the Launch milestone Jul 19, 2023
@gnprice gnprice modified the milestones: Launch, Beta 3 Nov 22, 2023
@sm-sayedi
Copy link
Collaborator

I would like to work on this one!

So far I've made it sorted by the name.

Before After

@gnprice
Copy link
Member

gnprice commented Mar 27, 2024

@sm-sayedi Sure, please do — assigning to you.

I think a good behavior to shoot for here would be to sort it the same way Zulip web does. There might be things that can be improved there, but if so then they should probably be changed there too. Two particular things I believe it uses that would be helpful:

  • people who've recently participated in the conversation you're looking at get shown sooner
  • people who you've had DM conversations with get shown sooner

In general we keep less message history in the mobile client than the web client, because of the different context, so that might affect what information we have for implementing some of the same features.

But if there are other kinds of data that would help implement the same features as web, and that we don't currently track in the store but are part of the /api/register-queue response, then we can take this as a prompt to add those to our API bindings and start tracking them in the store, as part of implementing this issue.

And as usual, if anything seems uncertain or you have any questions as you're going about that, please ask in #mobile-team and we'll be glad to discuss.

sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue Apr 2, 2024
@sm-sayedi
autocomplete: Sort user-mention autocomplete results
112f8f5 
Fixes: zulip#228
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue Apr 2, 2024
@sm-sayedi
autocomplete: Sort user-mention autocomplete results
20fefe8 
Fixes: zulip#228
@sm-sayedi sm-sayedi mentioned this issue Apr 2, 2024
Closed
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue Apr 2, 2024
@sm-sayedi
autocomplete: Sort user-mention autocomplete results
cefaf97 
Fixes: zulip#228
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue Apr 2, 2024
@sm-sayedi
autocomplete: Sort user-mention autocomplete results
7141342 
Fixes: zulip#228
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue Apr 4, 2024
@sm-sayedi
autocomplete: Sort user-mention autocomplete results
b419e14 
Fixes: zulip#228
@sm-sayedi sm-sayedi mentioned this issue Apr 5, 2024
Open
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue Apr 5, 2024
@sm-sayedi
autocomplete: Sort user-mention autocomplete results
997dd5a 
The @-mention autocomplete shows relevant results in the following order
of priority:
  * Recent conversation users
  * Recent DM users
  * Alphabetical order

Fixes: zulip#228
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue Apr 5, 2024
@sm-sayedi
autocomplete: Sort user-mention autocomplete results
981de92 
The @-mention autocomplete shows relevant results in the following order
of priority:
  * Recent conversation users
  * Recent DM users
  * Alphabetical order

Fixes: zulip#228
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue Apr 5, 2024
@sm-sayedi
autocomplete: Sort user-mention autocomplete results
22953d3 
The @-mention autocomplete shows relevant results in the following order
of priority:
  * Recent conversation users
  * Recent DM users
  * Alphabetical order

Fixes: zulip#228
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue Apr 16, 2024
@sm-sayedi
autocomplete: Sort user-mention autocomplete results
804287b 
The @-mention autocomplete shows relevant results in the following order
of priority:
  * Recent conversation users
  * Recent DM users
  * Alphabetical order

Fixes: zulip#228
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue Apr 16, 2024
@sm-sayedi
autocomplete: Sort user-mention autocomplete results
5508672 
The @-mention autocomplete shows relevant results in the following order
of priority:
  * Recent conversation users
  * Recent DM users
  * Alphabetical order

Fixes: zulip#228
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue Apr 19, 2024
@sm-sayedi
autocomplete: Sort user-mention autocomplete results
31deb52 
The @-mention autocomplete shows relevant results in the following order
of priority:
  * Recent conversation users
  * Recent DM users
  * Alphabetical order

Fixes: zulip#228
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue Apr 19, 2024
@sm-sayedi
autocomplete: Sort user-mention autocomplete results
6797b79 
The @-mention autocomplete shows relevant results in the following order
of priority:
  * Recent conversation users
  * Recent DM users
  * Alphabetical order

Fixes: zulip#228
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue Apr 29, 2024
@sm-sayedi
autocomplete: Sort user-mention autocomplete results
e431a00 
The @-mention autocomplete shows relevant results in the following order
of priority:
  * Recent conversation users
  * Recent DM users
  * Alphabetical order

Fixes: zulip#228
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue Apr 30, 2024
@sm-sayedi
autocomplete: Sort user-mention autocomplete results
d1f167f 
The @-mention autocomplete shows relevant results in the following order
of priority:
  * Recent conversation users
  * Recent DM users
  * Alphabetical order

Fixes: zulip#228
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue Apr 30, 2024
@sm-sayedi
autocomplete: Sort user-mention autocomplete results
a53e20a 
The @-mention autocomplete shows relevant results in the following order
of priority:
  * Recent conversation users
  * Recent DM users
  * Alphabetical order

Fixes: zulip#228
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue May 1, 2024
@sm-sayedi
autocomplete: Sort user-mention autocomplete results
38638a1 
The @-mention autocomplete shows relevant results in the following order
of priority:
  * Recent conversation users
  * Recent DM users
  * Alphabetical order

Fixes: zulip#228
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue May 7, 2024
@sm-sayedi
autocomplete: Sort user-mention autocomplete results
67194dd 
The @-mention autocomplete shows relevant results in the following order
of priority:
  * Recent conversation users
  * Recent DM users
  * Alphabetical order

Fixes: zulip#228
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue May 13, 2024
@sm-sayedi
autocomplete: Sort user-mention autocomplete results
706f3c6 
The @-mention autocomplete shows relevant results in the following order
of priority:
  * Recent conversation users
  * Recent DM users
  * Alphabetical order

Fixes: zulip#228
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue May 14, 2024
@sm-sayedi
autocomplete: Sort user-mention autocomplete results
9d455a9 
In @-mention autocomplete, users are suggested based on:
  1. Recent activity in the current stream.
  2. Recent DM conversations.
  3. Human vs. Bot users.
  4. Alphabetical order.

Fixes: zulip#228
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue Jul 1, 2024
@sm-sayedi
In @-mention autocomplete, users are suggested based on:
ff9c9d8 
  1. Recent activity in the current topic/stream.
  2. Recent DM conversations.

Note: By "recent activity" we mean recent messages sent to a topic/stream.

Fixes part of: zulip#228
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue Jul 1, 2024
@sm-sayedi
autocomplete: Add "recent activity in current topic/stream" criterion
751cace 
In @-mention autocomplete, users are suggested based on:
  1. Recent activity in the current topic/stream.
  2. Recent DM conversations.

Note: By "recent activity" we mean recent messages sent to a topic/stream.

Fixes part of: zulip#228
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue Jul 1, 2024
@sm-sayedi
autocomplete: Add "recent activity in current topic/stream" criterion
da5e69b 
In @-mention autocomplete, users are suggested based on:
  1. Recent activity in the current topic/stream.
  2. Recent DM conversations.

Note: By "recent activity" we mean recent messages sent to a topic/stream.

Fixes part of: zulip#228
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue Jul 3, 2024
@sm-sayedi
autocomplete: Add "recent activity in current topic/stream" criterion
d6b16c3 
In @-mention autocomplete, users are suggested based on:
  1. Recent activity in the current topic/stream.
  2. Recent DM conversations.

Note: By "recent activity" we mean recent messages sent to a topic/stream.

Fixes part of: zulip#228
@Khader-1 Khader-1 mentioned this issue Jul 3, 2024
Merged
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue Jul 11, 2024
@sm-sayedi
autocomplete: Add "recent activity in current topic/stream" criterion
d0c3f8d 
In @-mention autocomplete, users are suggested based on:
  1. Recent activity in the current topic/stream.
  2. Recent DM conversations.

Note: By "recent activity" we mean recent messages sent to a topic/stream.

Fixes part of: zulip#228
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue Jul 11, 2024
@sm-sayedi
autocomplete: Add "recent activity in current topic/stream" criterion
9e3d4ec 
In @-mention autocomplete, users are suggested based on:
  1. Recent activity in the current topic/stream.
  2. Recent DM conversations.

Note: By "recent activity" we mean recent messages sent to a topic/stream.

Fixes part of: zulip#228
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue Jul 18, 2024
@sm-sayedi
autocomplete: Add "recent activity in current topic/stream" criterion
4091454 
In @-mention autocomplete, users are suggested based on:
  1. Recent activity in the current topic/stream.
  2. Recent DM conversations.

Note: By "recent activity" we mean recent messages sent to a topic/stream.

Fixes part of: zulip#228
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue Jul 18, 2024
@sm-sayedi
autocomplete: Add "recent activity in current topic/stream" criterion
ef93c67 
In @-mention autocomplete, users are suggested based on:
  1. Recent activity in the current topic/stream.
  2. Recent DM conversations.

Note: By "recent activity" we mean recent messages sent to a topic/stream.

Fixes part of: zulip#228
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue Jul 19, 2024
@sm-sayedi
autocomplete: Add "recent activity in current topic/stream" criterion
8174059 
In @-mention autocomplete, users are suggested based on:
  1. Recent activity in the current topic/stream.
  2. Recent DM conversations.

Note: By "recent activity" we mean recent messages sent to a topic/stream.

Fixes part of: zulip#228
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue Jul 19, 2024
@sm-sayedi
autocomplete: Add "recent activity in current topic/stream" criterion
1805adc 
In @-mention autocomplete, users are suggested based on:
  1. Recent activity in the current topic/stream.
  2. Recent DM conversations.

Note: By "recent activity" we mean recent messages sent to a topic/stream.

Fixes part of: zulip#228
@sm-sayedi sm-sayedi mentioned this issue Jul 19, 2024
Merged
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue Jul 24, 2024
@sm-sayedi
autocomplete: Add "recent activity in current topic/stream" criterion
b5ed4d8 
In @-mention autocomplete, users are suggested based on:
  1. Recent activity in the current topic/stream.
  2. Recent DM conversations.

Note: By "recent activity" we mean recent messages sent to a topic/stream.

Fixes part of: zulip#228
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue Jul 24, 2024
@sm-sayedi
autocomplete: Add "recent activity in current topic/stream" criterion
5cc7896 
In @-mention autocomplete, users are suggested based on:
  1. Recent activity in the current topic/stream.
  2. Recent DM conversations.

Note: By "recent activity" we mean recent messages sent to a topic/stream.

Fixes part of: zulip#228
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue Jul 24, 2024
@sm-sayedi
autocomplete: Add "recent activity in current topic/stream" criterion
b816843 
In @-mention autocomplete, users are suggested based on:
  1. Recent activity in the current topic/stream.
  2. Recent DM conversations.

Note: By "recent activity" we mean recent messages sent to a topic/stream.

Fixes part of: zulip#228
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue Jul 24, 2024
@sm-sayedi
autocomplete: Add "recent DM conversations" criterion
09d3351 
In @-mention autocomplete, users are suggested based on:
  1. Recent DM conversations.

Fixes part of zulip#228
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue Jul 24, 2024
@sm-sayedi
autocomplete: Add "alphabetical order" criterion
2b5711b 
In @-mention autocomplete, users are suggested based on:
  1. Recent activity in the current stream.
  2. Recent DM conversations.
  3. Human vs. Bot users.
  4. Alphabetical order.

Fixes: zulip#228
gnprice pushed a commit to sm-sayedi/zulip-flutter that referenced this issue Jul 25, 2024
@sm-sayedi @gnprice
autocomplete: Add "recent activity in current topic/stream" criterion
5cd4eee 
In @-mention autocomplete, users are suggested based on:
  1. Recent activity in the current topic/stream.
  2. Recent DM conversations.

Note: By "recent activity" we mean recent messages sent to a topic/stream.

Fixes part of: zulip#228
@chrisbobbe
Copy link
Collaborator Author

@sm-sayedi with #828 merged, what remains to be done here? 🙂

@sm-sayedi
Copy link
Collaborator

As mentioned in #608 description:

  1. Human vs. Bot users.
  2. Alphabetical order.

So one other PR is needed to close this issue. 😃

@gnprice
Copy link
Member

gnprice commented Jul 26, 2024

Great!

Both of those sound like they'll be easier than the two we've already done — in particular they don't involve maintaining any new data structures. So looking forward to seeing those last two facets of this feature completed soon. 🙂

sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue Jul 29, 2024
@sm-sayedi
autocomplete: Add "alphabetical order" criterion
b4aa278 
In @-mention autocomplete, users are suggested based on:
  1. Recent activity in the current topic/stream.
  2. Recent DM conversations.
  3. Human vs. Bot users (human users come first).
  4. Alphabetical order.

Fixes: zulip#228
@sm-sayedi sm-sayedi mentioned this issue Jul 29, 2024
Merged
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue Jul 31, 2024
@sm-sayedi
autocomplete: Add "alphabetical order" criterion
f27a038 
In @-mention autocomplete, users are suggested based on:
  1. Recent activity in the current topic/stream.
  2. Recent DM conversations.
  3. Human vs. Bot users (human users come first).
  4. Alphabetical order.

Fixes: zulip#228
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue Aug 1, 2024
@sm-sayedi
autocomplete: Add "alphabetical order" criterion
0fbb56e 
In @-mention autocomplete, users are suggested based on:
  1. Recent activity in the current topic/stream.
  2. Recent DM conversations.
  3. Human vs. Bot users (human users come first).
  4. Alphabetical order.

Fixes: zulip#228
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue Aug 4, 2024
@sm-sayedi
autocomplete: Add "alphabetical order" criterion
e60629e 
In @-mention autocomplete, users are suggested based on:
  1. Recent activity in the current topic/stream.
  2. Recent DM conversations.
  3. Human vs. Bot users (human users come first).
  4. Alphabetical order.

Fixes: zulip#228
@gnprice gnprice closed this as completed in cef1769 Aug 9, 2024
@gnprice gnprice mentioned this issue Nov 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sm-sayedi sm-sayedi

Labels
a-compose Compose box, autocomplete, attaching files/images
Projects
Flutter app
Status: Done
Milestone
M3: Summer 2024
Development

Successfully merging a pull request may close this issue.

autocomplete: Add "human vs. bot user" and "Alphabetical order" criteria sm-sayedi/zulip-flutter
3 participants
@gnprice @chrisbobbe @sm-sayedi