Skip to content

test: Fix flake with identical consecutively autogenerated email addresses #1027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 26, 2024
Merged

test: Fix flake with identical consecutively autogenerated email addresses #1027

merged 1 commit into from
Oct 26, 2024

Conversation

chrisbobbe
Copy link
Collaborator

Fixes: #1026

@chrisbobbe chrisbobbe added the integration review Added by maintainers when PR may be ready for integration label Oct 25, 2024
@chrisbobbe chrisbobbe requested a review from gnprice October 25, 2024 23:40
@gnprice
Copy link
Member

gnprice commented Oct 26, 2024

Thanks for fixing this! Looks good — merging.

@PIG208 FYI (re #940). Detailed diagnosis is in the issue #1026.

@gnprice gnprice merged commit 1d2656b into zulip:main Oct 26, 2024
1 check passed
@chrisbobbe chrisbobbe deleted the pr-fix-flake-email-addresses branch January 15, 2025 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnprice gnprice Awaiting requested review from gnprice

Assignees

@gnprice gnprice

Labels
integration review Added by maintainers when PR may be ready for integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

test flake: Consecutive autogenerated email addresses are identical 0.1% of the time
2 participants
@chrisbobbe @gnprice