Fixed a google sign-in issue #1411
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the report. Would you please open an issue for this, and describe in more detail exactly what you did that led up to getting this unexpected prompt? I just tried to reproduce the issue, and it didn't reproduce — the flow worked normally as expected, with no prompt for an email app. A detailed set of steps will be helpful for making it possible to reproduce what you're seeing. After we better understand the issue, we can determine the right fix. A priori, I don't see why changing from having the browser appear in the app to externally would have any effect on this — and it would make the UX more cumbersome for everyone who's not running into this issue. |
|
What is the point when someone uses google sign-in and select an account and instead not directly login to the app it pops a "open with" dialog box to open that select ed email to open in these apps, gmail/outlook, i think its not good for the UX..
…________________________________
From: Greg Price ***@***.***>
Sent: Saturday, March 15, 2025 11:57 PM
To: zulip/zulip-flutter ***@***.***>
Cc: CT/2020/012 - HERMAN P.S.L. ***@***.***>; Author ***@***.***>
Subject: Re: [zulip/zulip-flutter] Fixed a google sign-in issue (PR #1411)
Thanks for the report. Would you please open an issue for this, and describe in more detail exactly what you did that led up to getting this unexpected prompt?
I just tried to reproduce the issue, and it didn't reproduce — the flow worked normally as expected, with no prompt for an email app. A detailed set of steps will be helpful for making it possible to reproduce what you're seeing.
After we better understand the issue, we can determine the right fix. A priori, I don't see why changing from having the browser appear in the app to externally would have any effect on this — and it would make the UX more cumbersome for everyone who's not running into this issue.
—
Reply to this email directly, view it on GitHub<#1411 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BHNRBVLA2ZMEJD345YAVDJT2URWKJAVCNFSM6AAAAABZCVQPOKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOMRWHEYTIMJYGQ>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
[gnprice]gnprice left a comment (zulip/zulip-flutter#1411)<#1411 (comment)>
Thanks for the report. Would you please open an issue for this, and describe in more detail exactly what you did that led up to getting this unexpected prompt?
I just tried to reproduce the issue, and it didn't reproduce — the flow worked normally as expected, with no prompt for an email app. A detailed set of steps will be helpful for making it possible to reproduce what you're seeing.
After we better understand the issue, we can determine the right fix. A priori, I don't see why changing from having the browser appear in the app to externally would have any effect on this — and it would make the UX more cumbersome for everyone who's not running into this issue.
—
Reply to this email directly, view it on GitHub<#1411 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BHNRBVLA2ZMEJD345YAVDJT2URWKJAVCNFSM6AAAAABZCVQPOKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOMRWHEYTIMJYGQ>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
|
Made a issue in github, could you refer it...
…-- regards --
________________________________
From: CT/2020/012 - HERMAN P.S.L. ***@***.***>
Sent: Sunday, March 16, 2025 12:13 AM
To: Greg Price ***@***.***>; zulip/zulip-flutter ***@***.***>; zulip/zulip-flutter ***@***.***>
Cc: Author ***@***.***>
Subject: Re: [zulip/zulip-flutter] Fixed a google sign-in issue (PR #1411)
What is the point when someone uses google sign-in and select an account and instead not directly login to the app it pops a "open with" dialog box to open that select ed email to open in these apps, gmail/outlook, i think its not good for the UX..
________________________________
From: Greg Price ***@***.***>
Sent: Saturday, March 15, 2025 11:57 PM
To: zulip/zulip-flutter ***@***.***>
Cc: CT/2020/012 - HERMAN P.S.L. ***@***.***>; Author ***@***.***>
Subject: Re: [zulip/zulip-flutter] Fixed a google sign-in issue (PR #1411)
Thanks for the report. Would you please open an issue for this, and describe in more detail exactly what you did that led up to getting this unexpected prompt?
I just tried to reproduce the issue, and it didn't reproduce — the flow worked normally as expected, with no prompt for an email app. A detailed set of steps will be helpful for making it possible to reproduce what you're seeing.
After we better understand the issue, we can determine the right fix. A priori, I don't see why changing from having the browser appear in the app to externally would have any effect on this — and it would make the UX more cumbersome for everyone who's not running into this issue.
—
Reply to this email directly, view it on GitHub<#1411 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BHNRBVLA2ZMEJD345YAVDJT2URWKJAVCNFSM6AAAAABZCVQPOKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOMRWHEYTIMJYGQ>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
[gnprice]gnprice left a comment (zulip/zulip-flutter#1411)<#1411 (comment)>
Thanks for the report. Would you please open an issue for this, and describe in more detail exactly what you did that led up to getting this unexpected prompt?
I just tried to reproduce the issue, and it didn't reproduce — the flow worked normally as expected, with no prompt for an email app. A detailed set of steps will be helpful for making it possible to reproduce what you're seeing.
After we better understand the issue, we can determine the right fix. A priori, I don't see why changing from having the browser appear in the app to externally would have any effect on this — and it would make the UX more cumbersome for everyone who's not running into this issue.
—
Reply to this email directly, view it on GitHub<#1411 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BHNRBVLA2ZMEJD345YAVDJT2URWKJAVCNFSM6AAAAABZCVQPOKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOMRWHEYTIMJYGQ>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
|
For cross-reference, it looks like this became the following issue: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Google Sign-In "Open With" Pop-Up Issue in _beginWebAuth
This PR fixes a misbehavior in the _beginWebAuth method in login.dart where clicking on a Google account during sign-in would trigger an "Open With" dialog, prompting users to choose an email app (Gmail, Outlook, etc.) instead of proceeding with authentication.
Issue: On the first click, the "Open With" menu appears, causing confusion. However, on the second click, authentication proceeds correctly.
Fix: The authentication URL now always opens in an external browser (LaunchMode.externalApplication), preventing the unwanted pop-up and ensuring a smooth login experience.
Impact: Users can now sign in with Google without being interrupted by the "Open With" pop-up.