Implement Custom Splash Screen for Zulip App #1414
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added Iconbutton with implementation of server URLs history, users can use the previous server URLs without typing.
SandaruEARL
deleted the
Implementation_of_previous_input_server_urls_suggestions_with_iconbutton
branch
|
I see you've opened a new PR #1415 instead of updating this one—in future, just update the original PR instead of making a new one. |
|
Thanks for response, I will do it that way.. |
SandaruEARL
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add URL History Dropdown to AddAccount Page
Description
This PR improves the server URL input experience by adding a history dropdown that allows users to quickly select previously used server URLs. The dropdown is accessible via a history icon button in the text field and provides a clean interface for selecting past entries or clearing the history.
Changes
Added ServerUrlHistory class to manage server URL history using SharedPreferences
Implemented history dropdown UI with animated transitions
Added ability to select history items with a single click
Added option to clear history
Ensured proper positioning and styling of the dropdown menu
Fixed layout issues with the dropdown positioning
Implementation Details
Used a Column layout approach instead of Stack/Positioned for better positioning
Added smooth animations for dropdown appearance/disappearance
Implemented proper scrolling for cases with many history items
Added visual separation between text field and dropdown
Testing
Tested on Samsung J7 prime (8.1 oreo)