Skip to content

local echo (3/n): Pull out MessageBase #1463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 15, 2025
Merged

local echo (3/n): Pull out MessageBase #1463

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
491de2e
api [nfc]: Make Message.fromJson a plain static method
PIG208 Apr 1, 2025
59bd688
api: Drop DmRecipient
PIG208 Apr 3, 2025
c17ce3e
api [nfc]: Pull out Conversation
PIG208 Mar 27, 2025
41a5ee3
api [nfc]: Place TopicName before Conversation
PIG208 Mar 27, 2025
f136d8e
api [nfc]: Pull out MessageBase, make Message generic
PIG208 Mar 27, 2025
575f1c6
msglist [nfc]: Migrate most MessageListItem subclasses to use Message…
PIG208 Mar 27, 2025
2c4085e
narrow test: Add containsMessage tests for ChannelNarrow and TopicNarrow
PIG208 Apr 15, 2025
5ec097c
narrow [nfc]: Make containsMessage support MessageBase
PIG208 Apr 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/api/model/events.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -679,7 +679,7 @@ class MessageEvent extends Event {
// events and in the get-messages results is that `matchContent` and
// `matchTopic` are absent here. Already [Message.matchContent] and
// [Message.matchTopic] are optional, so no action is needed on that.
@JsonKey(readValue: _readMessageValue, includeToJson: false)
@JsonKey(readValue: _readMessageValue, fromJson: Message.fromJson, includeToJson: false)
final Message message;

// When present, this equals the "local_id" parameter
Expand Down
Loading